dynamic host volumes: create/register RPC validation #24482
+560
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
force-pushed
the
dhv-rpc-validation
branch
from
788faa7
to
8b5f3d0
Compare
tgross
force-pushed
the
dhv-rpc-validation
branch
from
8b5f3d0
to
b0c16b2
Compare
The `HostVolumeByID` state store method didn't add a watch channel to the watchset, which meant that it would never unblock. The tests missed this because they were racy, so move the updates for unblocking tests into a `time.After` call to ensure the queries are blocked before the update happens.
Add several validation steps in the create/register RPCs for dynamic host volumes. We first check that submitted volumes are self-consistent (ex. max capacity is more than min capacity), then that any updates we've made are valid. And we validate against state: preventing claimed volumes from being updated and preventing placement requests for nodes that don't exist. Ref: #15489
tgross
force-pushed
the
dhv-rpc-validation
branch
from
bf4da7d
to
d8cb133
Compare
gulducat
reviewed
Nov 19, 2024
Comment on lines
+509
to
+513
| func FlattenMultierror(err error) error { | ||
| if err == nil { | ||
| return nil | ||
| } | ||
| mErr := err.(*multierror.Error) |
There was a problem hiding this comment.
I would conditionally type cast this, so a standard error could be passed in, and just returned right away. then the extra if mErr == nil check below seems superfluous given this new nil check up top, eh?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add several validation steps in the create/register RPCs for dynamic host volumes. We first check that submitted volumes are self-consistent (ex. max capacity is more than min capacity), then that any updates we've made are valid. And we validate against state: preventing claimed volumes from being updated and preventing placement requests for nodes that don't exist.
Ref: #15489