Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dynamic host volumes: create/register RPC validation #24482

Open
wants to merge 3 commits into
base: dynamic-host-volumes
Choose a base branch
from
Open

dynamic host volumes: create/register RPC validation #24482

wants to merge 3 commits into from
+560 −54

Commits on Nov 19, 2024

  1. allow FlattenMultierror to accept standard error

    @tgross
    tgross committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    e256d83 View commit details
    Browse the repository at this point in the history

  2. dynamic host volumes: fix unblocking bug in state store 

    The `HostVolumeByID` state store method didn't add a watch channel to the
watchset, which meant that it would never unblock. The tests missed this because
they were racy, so move the updates for unblocking tests into a `time.After`
call to ensure the queries are blocked before the update happens.
    @tgross
    tgross committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    e48025e View commit details
    Browse the repository at this point in the history

  3. dynamic host volumes: create/register RPC validation 

    Add several validation steps in the create/register RPCs for dynamic host
volumes. We first check that submitted volumes are self-consistent (ex. max
capacity is more than min capacity), then that any updates we've made are
valid. And we validate against state: preventing claimed volumes from being
updated and preventing placement requests for nodes that don't exist.

Ref: #15489
    @tgross
    tgross committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    d8cb133 View commit details
    Browse the repository at this point in the history