1806 manufacture #1896
Merged
1806 manufacture #1896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiasNx
force-pushed
the
1806-manufacture
branch
from
d975589
to
77c9b96
Compare
acka47
requested changes
Sep 21, 2023
| "manufacture" : [ { | ||
| "startDate" : "1994", | ||
| "type" : [ "Event" ], | ||
| "location" : [ "EMI Records Ltd, p 1969" ] |
There was a problem hiding this comment.
This seems wrong. It should rather read "manufacturer" or similar and we should put the actual place of manufacture in this field.
There was a problem hiding this comment.
This is written in:
$a - Place of production, publication, distribution, manufacture (R)
this seems to be a cataloguing error.
TobiasNx
force-pushed
the
1806-manufacture
branch
from
77c9b96
to
8e3d3dc
Compare
TobiasNx
commented
Sep 21, 2023
| "startDate" : "2010", | ||
| "type" : [ "Event" ], | ||
| "location" : [ "Marsberg" ], | ||
| "manufacturedBy" : [ "Boxberger" ] |
There was a problem hiding this comment.
@acka47 This is a better example.
|
@dr0i you can merge this |
|
ahh, but first I have to update the test |
|
Will be deployed next Monday. |
|
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1806
Add manufacture analog to publication.
Needs to be done/answered, @acka47 can you help:
sdo:Eventis good enough, since it is no PublishingEvent and Event is the "parent"(?) class.@blackwinter is this what you had in mind?