Skip to content

Commit

Permalink
remove caching from reports image
Browse files Browse the repository at this point in the history
complexity and unlikely use vs 2 minute build time seem like an unnecessary tradeoff
  • Loading branch information
brianhenryhf committed Oct 30, 2024
1 parent dfc44fa commit f2e6c82
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 12 deletions.
2 changes: 1 addition & 1 deletion .docker/Dockerfile.gha-reports
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ RUN apt-get update \
RUN touch ~/.bashrc
ENV BASH_ENV=~/.bashrc

curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.1/install.sh | bash
RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.1/install.sh | bash
RUN nvm install 20 && \
nvm use 20 && nvm alias default 20 && \
npm install -g npm@10.9.0 && \
Expand Down
11 changes: 0 additions & 11 deletions .github/workflows/build-reports-image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -121,17 +121,6 @@ jobs:
install: true
version: v0.17.1

# Cache layers specific to current sha, but allow rummaging through older caches if none for current
# TODO determine if this would need to be fixed to actually cache seomthing (and what key should be, w/r/t not
# destructively colliding with normal build cache, and meaningful sha (presumably sha from inputs?) or whatnot.
# - name: Cache Docker layers
# uses: actions/cache@v4
# with:
# path: /tmp/.buildx-cache
# key: ${{ runner.os }}-buildx-${{ github.sha }}
# restore-keys: |
# ${{ runner.os }}-buildx

- name: Login to GHCR
uses: docker/login-action@v3
with:
Expand Down

0 comments on commit f2e6c82

Please sign in to comment.