cmake: Disable WITH_EXTERNAL_SIGNER when FUZZ=ON
#128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable WITH_EXTERNAL_SIGNER when FUZZ=ON. The behavior is aligned with the master branch.
|
Friendly ping @pablomartin4btc @dergoegge :) |
pablomartin4btc
approved these changes
Mar 24, 2024
There was a problem hiding this comment.
tACK
Tested on Ubuntu 22.04.
Issue from description has been fixed with this PR: EXTERNAL_SIGNER optional feature is OFF now when DFUZZ=ON as in master.
git clone --depth=1 --branch 240324-cmake-CS https://github.com/hebasto/bitcoin.git bitcoin-hebasto
cd bitcoin-hebasto
cmake -B build \
-DCMAKE_C_COMPILER="clang" \
-DCMAKE_CXX_COMPILER="clang++" \
-DCMAKE_BUILD_TYPE=None \
-DFUZZ=ON \
-DSANITIZERS=undefined,address,fuzzer
...
Configure summary
=================
Executables:
bitcoind ............................ OFF
bitcoin-cli ......................... OFF
bitcoin-tx .......................... OFF
bitcoin-util ........................ OFF
bitcoin-wallet ...................... OFF
Wallet support:
SQLite, descriptor wallets .......... ON
Berkeley DB, legacy wallets ......... OFF
Optional packages:
GUI ................................. OFF
external signer ..................... OFF
NAT-PMP ............................. OFF
UPnP ................................ OFF
ZeroMQ .............................. OFF
USDT tracing ........................ ON
Tests:
test_bitcoin ........................ OFF
test_bitcoin-qt ..................... OFF
bench_bitcoin ....................... OFF
fuzz binary ......................... ON
...
dergoegge
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior is aligned with the master branch.
First noticed in #89 (review).