-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake: Ignore build subdirectories within the source directory #302
Conversation
/*build* | ||
!/build-aux | ||
!/build_msvc | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a CLion expert, but it seems inappropriate to create build artifacts anywhere outside of the CMake's designated binary tree. Is this configurable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see that "cmake-build-debug" is a configured name of the build directory for the "Debug" build type. It is OK to have multiple build directories simultaneously. The suggested pattern /*build*
covers all such cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened https://youtrack.jetbrains.com/issue/CPP-39809/cmake-build-run-config-folders-should-be-created-inside-the-build-folder-by-default, thanks for checking
Just to clarify, based on #302 (comment), I don't consider https://youtrack.jetbrains.com/issue/CPP-39809/cmake-build-run-config-folders-should-be-created-inside-the-build-folder-by-default to be a bug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, will let them decide, they have all the context here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK ff39f0b
ff39f0b
to
57cdcdf
Compare
ACK 57cdcdf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
It was planned to clean up the
.gitignore
file during the removal of the Autotools and MSVC legacy build systems. However, reviewers requested it earlier.Therefore, delivering it now :)