Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: Ignore build subdirectories within the source directory #302

Merged
merged 1 commit into from
Aug 6, 2024
+5 −0
Merged

cmake: Ignore build subdirectories within the source directory #302

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
# Build subdirectories.
/*build*
!/build-aux
hebasto marked this conversation as resolved.
Show resolved Hide resolved
!/build_msvc

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the mentioned cmake-build-debug and cmake-build-debug-coverage folders were created outside of build by default:

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a CLion expert, but it seems inappropriate to create build artifacts anywhere outside of the CMake's designated binary tree. Is this configurable?

Copy link

@l0rinc l0rinc Aug 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but it's not the default, I'll open an issue

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened https://youtrack.jetbrains.com/issue/CPP-39809/cmake-build-run-config-folders-should-be-created-inside-the-build-folder-by-default, thanks for checking

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see that "cmake-build-debug" is a configured name of the build directory for the "Debug" build type. It is OK to have multiple build directories simultaneously. The suggested pattern /*build* covers all such cases.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened https://youtrack.jetbrains.com/issue/CPP-39809/cmake-build-run-config-folders-should-be-created-inside-the-build-folder-by-default, thanks for checking

Just to clarify, based on #302 (comment), I don't consider https://youtrack.jetbrains.com/issue/CPP-39809/cmake-build-run-config-folders-should-be-created-inside-the-build-folder-by-default to be a bug.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, will let them decide, they have all the context here

*.tar.gz

*.exe
Expand Down
Loading