Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Maintain build-time dependencies for the check-symbols and check-security targets #332

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

hebasto
Copy link
Owner

@hebasto hebasto commented Aug 16, 2024

It was noted offline:

I don’t really see why targets, which have dependencies, should, rather than adding those dependencies, instead rely on running the right commands in the right order. That seems like fragile design?

This PR fixes this issue.

Maintain build-time dependencies for the `check-symbols` and
`check-security` targets.
@hebasto
Copy link
Owner Author

hebasto commented Aug 16, 2024

Rebased on top of the merged #333.

@hebasto hebasto added the bug Something isn't working label Aug 16, 2024
Copy link

@TheCharlatan TheCharlatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hebasto hebasto merged commit 950af8d into cmake-staging Aug 16, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants