Landtype Boosting #789
Merged
Landtype Boosting #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- initialize hexes without a landtype assignment - load landtype disktree - update tests to match HIP-103 chart with all 3 data sets
HexAssignemnts wrap and labels Assignments. The order Assignments are considered is not always clear unless you have HIP-103 up next to the code. So we try to funnel all uses of the fields together into one place, and callers deal with Assignments as a collection.
This is an attempt to simplify the trait soup hex boosting was starting to become. Until there is a concrete need for more traits, I believe this flow is easier to follow, and easier to mock at the level desired in tests.
This command makes sure all values in a disktree file can be turned into Assignment.
Now a geofence can be constructed directly without needing to go through a file if you have a HexTreeSet.
The tables in HIP-103 list the assignments (AAA, ABC, etc,.) in the order (footfall, landtype, urbanized). Having the Debug repr of Assignments print in the same order makes it easier to cross reference with the tables.
This test will break if the logic for deriving scores changes. If the break is on purpose, the test should be updated.
bbalser
reviewed
Apr 18, 2024
bbalser
reviewed
Apr 18, 2024
bbalser
reviewed
Apr 18, 2024
andymck
reviewed
Apr 19, 2024
This forces us to go through the proto enum, but provides a stronger contract for going between types. very nice
bbalser
approved these changes
Apr 20, 2024
andymck
approved these changes
Apr 22, 2024
maplant
approved these changes
Apr 23, 2024
kurotych
reviewed
Apr 24, 2024
Comment on lines
+94
to
+95
| // gray - Outside of USA | ||
| (_, _, C) => dec!(0.00), |
There was a problem hiding this comment.
Does it mean that all radios outside of the USA won't receive any coverage points?
What about Mexico?
There was a problem hiding this comment.
HIP-103 contains this paragraph, so radios in Mexico only get PoC if they are in a boosted hex and the oracle_multiplier is auto set to 1.
Further, the HIP authors acknowledge that areas that Service Providers boost through hex boosting are areas where coverage is needed the most. Therefore, if a res12 hex is boosted by a Service Provider of ≥1, the Oracle Multiplier will automatically be 1.00X, regardless of what combination value it is assigned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
helium/proto#398
Add Landtype to Hex Boosting.
struct HexAssignmentsAssignmentsare never considered individually, nor should they be. This type packs them together, allowing any code that requires specific use ofAssignmentorder to attach itself here.It also allows
boostring_oracles/mod.rsto reduce it's reliance on traits. There is now a single exportedBoostedHexAssignmentsthat allows for getting aHexAssignments.HexBoostDataandCoverageDaemonWith only exporting a single trait from
boosting_oracles/mod.rs, theCoverageDaemonnow takes the concrete structHexBoostDatawith no generic arguments.Downstream from the
CoverageDaemon, functions will takeimpl BoostedHexAssignmentsso they can be used in tests.verify-disktree --path <PATH> --type <TYPE>CLI CommandA CLI command was added to
mobile-verifier.It verifies a
.h3treefile by making sure that every cell can be turned into anAssignment.Current only
Landtypeis supported.NOTE: In release mode, this function took about 8 minutes to run on my 2.3GHz Intel MacBook Pro for a 28gb file.
Other
Geofence::newwithGeofence::from_pathssonewcould used without touching the filesystem.