Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landtype Boosting #789

Merged
merged 15 commits into from
Apr 24, 2024
Merged

Landtype Boosting #789

merged 15 commits into from
Apr 24, 2024

Commits on Apr 13, 2024

  1. add landtype to hex boosting

    - initialize hexes without a landtype assignment
    - load landtype disktree
    - update tests to match HIP-103 chart with all 3 data sets
    michaeldjeffrey committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    b649310 View commit details
    Browse the repository at this point in the history
  2. use struct HexAssignments

    HexAssignemnts wrap and labels Assignments. The order Assignments are
    considered is not always clear unless you have HIP-103 up next to the
    code. So we try to funnel all uses of the fields together into one
    place, and callers deal with Assignments as a collection.
    michaeldjeffrey committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    8a09846 View commit details
    Browse the repository at this point in the history
  3. reify HexBoostData for CoverageDaemon

    This is an attempt to simplify the trait soup hex boosting was starting
    to become. Until there is a concrete need for more traits, I believe
    this flow is easier to follow, and easier to mock at the level desired
    in tests.
    michaeldjeffrey committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    a111595 View commit details
    Browse the repository at this point in the history
  4. remove unused trait

    michaeldjeffrey committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    12e6213 View commit details
    Browse the repository at this point in the history
  5. add mobile-verifier command to verify disktree

    This command makes sure all values in a disktree file can be turned into
    Assignment.
    michaeldjeffrey committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    a3fccfb View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    48c3419 View commit details
    Browse the repository at this point in the history
  7. add from_paths constructor to Geofence

    Now a geofence can be constructed directly without needing to go through
    a file if you have a HexTreeSet.
    michaeldjeffrey committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    e5f3c75 View commit details
    Browse the repository at this point in the history
  8. match printing order with HIP order

    The tables in HIP-103 list the assignments (AAA, ABC, etc,.) in the
    order (footfall, landtype, urbanized). Having the Debug repr of
    Assignments print in the same order makes it easier to cross reference
    with the tables.
    michaeldjeffrey committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    9618d74 View commit details
    Browse the repository at this point in the history
  9. Unit test for HexAssignments

    This test will break if the logic for deriving scores changes. If the
    break is on purpose, the test should be updated.
    michaeldjeffrey committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    95b747d View commit details
    Browse the repository at this point in the history
  10. match comments

    michaeldjeffrey committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    99d1318 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    95bd9ce View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Configuration menu
    Copy the full SHA
    575bb4f View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. Configuration menu
    Copy the full SHA
    d73b42e View commit details
    Browse the repository at this point in the history
  2. implement From for the proto type, avoid base type

    This forces us to go through the proto enum, but provides a stronger
    contract for going between types. very nice
    michaeldjeffrey committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    969b9f8 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Configuration menu
    Copy the full SHA
    8d3449c View commit details
    Browse the repository at this point in the history