-
Notifications
You must be signed in to change notification settings - Fork 7
Improvements to the ROS2 Navigation menu, examples, and overview pages. #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…holder for a Sensors tutorial, and funmap links to the README awaiting a plugin that embeds github links.
…ink to use 0.3 in teleoperating_stretch.
…tch their content where they were wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I've left some suggestions on organization. I'd recommend going through to fill out some of the content + reorganize things to make it cohesive.
mkdocs_rt.yml
Outdated
# - Writing Nodes: ./writing_nodes.md # TODO | ||
- Navigation with Nav2: | ||
- Overview: ./README.md | ||
- Creating Packages & Nodes: ./writing_nodes.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tutorial needs to be written: https://github.com/hello-robot/stretch_tutorials/blob/feature/ros2-nav/ros2/writing_nodes.md
ros2/stretch_simulation.md
Outdated
@@ -0,0 +1,6 @@ | |||
# Spawning Stretch in Simulation | |||
|
|||
{% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's write content meant for new users. I'd follow the structure of the ROS1 Gazebo tutorial: https://docs.hello-robot.com/0.2/stretch-tutorials/ros1/gazebo_basics/
I'd note how one could follow this tutorial series purely in sim. I'd also note the computational requirements.
ros2/teleoperating_stretch.md
Outdated
@@ -1,10 +1,10 @@ | |||
## Teleoperating Stretch | |||
|
|||
!!! note |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get rid of this banner
- RViz Tutorial: ./rviz_basics.md | ||
- Follow Joint Trajectory & Joint States: ./follow_joint_trajectory.md | ||
- Motion Commands via hello_utils: ./jogging.md | ||
- Robot Driver: ./robot_drivers.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be fleshed out: https://github.com/hello-robot/stretch_tutorials/blob/feature/ros2-nav/ros2/robot_drivers.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can move the sensor stuff into sensors_tutorial.md
# - Navigation: ./writing_nodes.md #TODO | ||
# - Manipulation: ./writing_nodes.md # TODO | ||
- Perception: ./perception.md | ||
- Perception Tutorial: ./perception.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge this into rviz_basics.md
@@ -1,4 +1,5 @@ | |||
## Example 10 | |||
|
|||
!!! note |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove the banner
ros2/align_to_aruco.md
Outdated
## Computing Transformations | ||
|
||
If you have not already done so, now might be a good time to review the [tf listener](https://docs.hello-robot.com/latest/ros2/example_10/) tutorial. Go on, we can wait... | ||
If you have not already done so, now might be a good time to review the [tf listener](https://docs.hello-robot.com/latest/ros2/tf2_transforms/) tutorial. Go on, we can wait... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove stuff like "Go on, we can wait..."
- Tf2 Listener and Broadcaster: ./tf2_transforms.md | ||
- Realsense Camera: ./realsense_camera.md | ||
- Align to ArUco Tutorial: ./align_to_aruco.md | ||
- ArUco Locator: ./aruco_locator.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge aruco_locator.md and aruco_marker_detection.md
To add:
|
No description provided.