2X faster vmec_fieldlines #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Date: Sun Jul 3 21:25:39 2022 -0400 Committer: Rahul Gaur <rg6256@stellar-intel.princeton.edu> modified: ../../src/simsopt/mhd/vmec_diagnostics.py modified: test_vmec_diagnostics.py
Codecov Report
@@ Coverage Diff @@
## master #243 +/- ##
=======================================
Coverage 91.80% 91.80%
=======================================
Files 60 60
Lines 8984 8985 +1
=======================================
+ Hits 8248 8249 +1
Misses 736 736
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
landreman
requested changes
Aug 1, 2022
|
Also, |
vmec_fieldlines: reduced number of iterations for root finding
landreman
approved these changes
Aug 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
In the
vmec_diagnostics.pyscript, to find theta_vmec for a given theta_pest, one needs a non-linear root-finding algorithm. I have added a faster root finder to the vmec_fieldlines function. This function, written by Alan Goodman, speeds up the root-finding procedure by a factor of eight and the vmec_fieldlines function by at least a factor of two.