Implement Stage Instances #1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
|
discord/discord-api-docs#5687 was merged last night so I'm gonna keep this as a draft until I get a moment to add this in. I have it committed locally but haven't had the chance to test yet. |
davfsa
requested changes
Oct 3, 2023
davfsa
reviewed
Oct 28, 2023
add stubs fix linting make names more consistent. started adding tests change stage_id to id rename stage_instance_events to stage_events. add helpful functions and modify abc thing rename and fix linting fix bugs + add tests for event manager add tests for stage events and fix some bugs add tests for stage_instance fix linting add tests and fix small bugs
Just brought it up to date with the current version (at time of writing)
`guild_scheduled_event_id` was recently merged into DAPI docs. `send_start_notification` was added to Create Stage Instance some time ago, so I added that in too.
Co-authored-by: davfsa <davfsa@gmail.com> Signed-off-by: nulldomain <git@nulldoma.in>
Co-authored-by: davfsa <davfsa@gmail.com> Signed-off-by: nulldomain <git@nulldoma.in>
davfsa
reviewed
Dec 7, 2023
Co-authored-by: davfsa <davfsa@gmail.com> Signed-off-by: nulldomain <git@nulldoma.in>
Co-authored-by: davfsa <davfsa@gmail.com> Signed-off-by: nulldomain <git@nulldoma.in>
Co-authored-by: davfsa <davfsa@gmail.com> Signed-off-by: nulldomain <git@nulldoma.in>
davfsa
previously approved these changes
Dec 7, 2023
|
@FasterSpeeding please review when you can :) |
|
@FasterSpeeding Can you review please? |
|
Asides from those few small things LGTM |
beagold
reviewed
Apr 14, 2024
davfsa
reviewed
Aug 3, 2024
Co-authored-by: davfsa <davfsa@gmail.com> Signed-off-by: thomm.o <43570299+tandemdude@users.noreply.github.com>
Co-authored-by: davfsa <davfsa@gmail.com> Signed-off-by: thomm.o <43570299+tandemdude@users.noreply.github.com>
davfsa
approved these changes
Aug 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to finish the work made by @ashwinvin in #695, including rebasing on the most recent hikari version (at the time of writing) and bringing tests up to scratch.
Hopefully I haven't missed anything, I only had a few hours to look at this.
Checklist
noxand all the pipelines have passed.Related issues
Closes #695
Closes #602