Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Stage Instances #1725

Merged
merged 34 commits into from
Aug 3, 2024
Merged
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
cb9f9f5
Implement Stage instances
ashwinvin Jul 9, 2021
67996b8
Rebased and improved
null-domain Sep 28, 2023
f5704cc
Fix failing test
null-domain Sep 28, 2023
ddef5a2
Don't cry, towncrier
null-domain Sep 28, 2023
d99b5d5
Add missing attributes to Stage instances
null-domain Oct 2, 2023
f7fd4d5
Don't use spec_set in stageinstance mock app test
null-domain Oct 4, 2023
1a77a6a
Update tests/hikari/events/test_stage_events.py
null-domain Oct 4, 2023
f42191a
Remove deprecated stage instance privacy level
null-domain Oct 4, 2023
f2e78d6
Lowercase *every instance of "stage instance"
null-domain Oct 4, 2023
ff65fb6
Triple quote docstring
null-domain Oct 4, 2023
36ce0b9
Cast guild_scheduled_event_id to snowflake
null-domain Oct 4, 2023
b8ec2c1
Move note about UnauthorizedError to the right place
null-domain Oct 4, 2023
d4f114a
Turns out g_s_e_id is always in the payload, just set as None
null-domain Oct 4, 2023
ef7ed23
Correct info/raised exc about non-existent stage instance
null-domain Oct 4, 2023
7aed3d3
Remove unused imports, black changes
null-domain Oct 4, 2023
3bfaf63
Fix failing tests, remove remaining refs to deprecated attribute
null-domain Oct 4, 2023
e666ed5
guild_scheduled_event_id should be None instead of UNDEFINED
null-domain Oct 4, 2023
594c3a6
Remove unused import
null-domain Oct 4, 2023
cbd64c9
Extract guild_scheduled_event_id to its own variable
davfsa Oct 28, 2023
e2f4b43
Add missing tests
null-domain Nov 2, 2023
6692e38
Merge branch 'master' into feat/stage-instances
null-domain Nov 3, 2023
423302d
Merge branch 'master' into feat/stage-instances
null-domain Nov 15, 2023
a6dd630
Update hikari/internal/routes.py
null-domain Dec 7, 2023
0358720
Update hikari/api/rest.py
null-domain Dec 7, 2023
144f93d
Update hikari/api/rest.py
null-domain Dec 7, 2023
257e387
Merge branch 'master' into feat/stage-instances
null-domain Dec 20, 2023
e1b0cf4
Merge branch 'master' into thommo-stage-instances-patch
tandemdude Aug 2, 2024
8429ded
Address PR comments and fix flake8 errors
tandemdude Aug 2, 2024
5bc6021
Update hikari/stage_instances.py
tandemdude Aug 3, 2024
1d71179
Apply suggestions from code review
tandemdude Aug 3, 2024
6dd22a4
Address final comments, ensure pipelines pass
tandemdude Aug 3, 2024
2cf82d7
Implement StageInstancePrivacyLevel, fix incorrect tests
tandemdude Aug 3, 2024
944d49b
Remove stage_instance_id from events, fix formatting
tandemdude Aug 3, 2024
aa0025b
Fix tests and flake8
tandemdude Aug 3, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Turns out g_s_e_id is always in the payload, just set as None
  • Loading branch information
null-domain committed Nov 2, 2023

Verified

This commit was signed with the committer’s verified signature.
WhosNickDoglio Nicholas Doglio
commit d4f114ad768b5d8cb0b9f777436d80a6851dc862
2 changes: 1 addition & 1 deletion hikari/impl/entity_factory.py
Original file line number Diff line number Diff line change
@@ -1476,7 +1476,7 @@ def deserialize_stage_instance(self, payload: data_binding.JSONObject) -> stage_
topic=payload["topic"],
discoverable_disabled=payload["discoverable_disabled"],
guild_scheduled_event_id=snowflakes.Snowflake(payload["guild_scheduled_event_id"])
if "guild_scheduled_event_id" in payload
if payload["guild_scheduled_event_id"]
else undefined.UNDEFINED,
)