Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure schema generation is robust to nans and await describe_data call #724

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

philippjfr
Copy link
Member

As the title says, there was an oversight which meant await wasn't called in the describe_data utility. Also the schema generation for the DuckDBSource was not robust to nans.

@philippjfr philippjfr merged commit bd4d92e into main Oct 16, 2024
10 checks passed
@philippjfr philippjfr deleted the fix_schema_calls branch October 16, 2024 07:51
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 55.82%. Comparing base (c2ea8c9) to head (d767527).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
lumen/ai/utils.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #724      +/-   ##
==========================================
+ Coverage   55.81%   55.82%   +0.01%     
==========================================
  Files          98       98              
  Lines       11879    11881       +2     
==========================================
+ Hits         6630     6633       +3     
+ Misses       5249     5248       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant