Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure schema generation is robust to nans and await describe_data call #724

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Ensure schema generation is robust to nans and await describe_data call #724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lumen/ai/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,8 +241,7 @@ def describe_data_sync(df):
"stats": df_describe_dict,
}

data = asyncio.to_thread(describe_data_sync, df)
return data
return await asyncio.to_thread(describe_data_sync, df)


def clean_sql(sql_expr):
Expand Down
7 changes: 5 additions & 2 deletions lumen/sources/duckdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
from typing import TYPE_CHECKING, Any

import duckdb
import pandas as pd
import param

from ..config import config
Expand Down Expand Up @@ -321,8 +322,10 @@ def get_schema(
cast = str
else:
cast = lambda v: v
schema[col]['inclusiveMinimum'] = cast(minmax_data[f'{col}_min'].iloc[0])
schema[col]['inclusiveMaximum'] = cast(minmax_data[f'{col}_max'].iloc[0])
min_data = minmax_data[f'{col}_min'].iloc[0]
schema[col]['inclusiveMinimum'] = min_data if pd.isna(min_data) else cast(min_data)
max_data = minmax_data[f'{col}_max'].iloc[0]
schema[col]['inclusiveMaximum'] = max_data if pd.isna(max_data) else cast(max_data)

count_expr = SQLCount().apply(sql_expr)
count_expr = ' '.join(count_expr.splitlines())
Expand Down
Loading