-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only allow named extension array tests #89
base: main
Are you sure you want to change the base?
Only allow named extension array tests #89
Conversation
When you run
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general I'd be against something like this, but these are desperate times, and it does sound like it would address the underlying problem that new tests added upstream seem to have a very low probability of revealing genuine issues and a very high probability of breaking our builds. In the past couple of years I don't recall one of those tests revealing such a problem, but I do recall many, many breaks to our build. So I'm ok with holding our noses and putting this in place if you are!
@jbednar Maybe we hold off merging this for the moment and keep it in reserve whilst I fix the other CI problems. |
4d46c03
to
88ce1f8
Compare
This is a possible (temporary?) fix to the problem of new pandas versions including new extension array tests that break our CI. The fix is to only run extension array tests with particular names, so the creation of a new test will not cause our existing CI to fail.
The solution isn't very elegant and I'm not sure I really like it, but it does fix the problem.