Welling/assay rules pre post #700
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…taEndpoint Initial release for ingest-api#670, use new entity-api /prov-metadata…
|
It looks like some test fixtures do not match the new json schema for the rule chain. I will update them. |
|
@jswelling Can you sync the latest |
…PI /prov-metadata fails. Make bit-wise XOR operation with bool values explicit and commented.
…taEndpoint Return 500 errors when entity-api does not return 200, revise XOR usage
|
@yuanzhou I have merged the current main as requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR breaks the assayclassifier rule chain into separate segments for pre- and post-processing in addition to the main 'body' rules. This permits moving much of the logic that was hard-coded in the previous version into the rule chains themselves.
The rule chain schema is updated correspondingly. A separate module is added for a generic source_is_human() function designed to work consistently across HuBMAP and SENNET.