Make @retry_endpoint a default for all test
#1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1725 +/- ##
===========================================
+ Coverage 49.19% 82.50% +33.31%
===========================================
Files 62 62
Lines 7265 7265
===========================================
+ Hits 3574 5994 +2420
+ Misses 3691 1271 -2420 ☔ View full report in Codecov by Sentry. |
LysandreJik
approved these changes
Oct 12, 2023
|
Thanks for the quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently use
@retry_endpointon endpoint tests to retry on HTTPError 504 or OSError (git clone race condition). It has being introduced in #682 to improve stability of the CI. What's still annoying is that it is a decorator that has to be added to every test case individually -which is prone to forgetting. This PR updates the CI by automatically applying the retry mechanism to all tests.(Note: if in the future we specifically want to opt-out some tests, it is still doable using a
pytest.mark. But I don't see a reason to do it.).