added common_dir

[BOOTCFG]

Summary by CodeRabbit

• New Features
  • Updated configuration for the husarion_ugv_ros service to include a new parameter for initialization.
• Bug Fixes
  • Ensured consistent service initialization for husarion_ugv_ros.

[coderabbitai]

Walkthrough

The changes in this pull request involve modifications to the demo/compose.minimal-setup.yaml file, specifically for the husarion_ugv_ros service. The command for the husarion_ugv_ros service has been updated to include a new parameter, common_dir_path:=/config, affecting its initialization. The gamepad_controller service remains unchanged in terms of its structure and command, with no modifications to its configuration for volumes, devices, or device cgroup rules.

Changes

File	Change Summary
demo/compose.minimal-setup.yaml	- Updated command for husarion_ugv_ros service to include common_dir_path:=/config. - gamepad_controller service remains unchanged.

Possibly related PRs

• ROS 2 husarion UGV #92: The changes in demo/compose.minimal-setup.yaml regarding the husarion_ugv_ros service and its command are directly related to the modifications in the Dockerfile.hardware and Dockerfile.simulation, which also focus on the husarion_ugv package and its configuration.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 1a21df2 and 848ccab.

📒 Files selected for processing (1)

• demo/compose.minimal-setup.yaml (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• demo/compose.minimal-setup.yaml

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

demo/compose.minimal-setup.yaml (1)

Line range hint 1-24: Well-structured configuration with good architectural practices!

The configuration demonstrates several good practices:

1. Uses YAML anchors for common configuration
2. Proper separation of configuration through volume mounts
3. Appropriate security constraints with device cgroup rules
4. Proper real-time settings for hardware control

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 024e121 and 1a21df2.

📒 Files selected for processing (1)

• demo/compose.minimal-setup.yaml (1 hunks)

🔇 Additional comments (1)

demo/compose.minimal-setup.yaml (1)

37-37: LGTM! The command parameter aligns with the mounted volume.

The added parameter common_dir:=/config correctly references the mounted volume from /home/husarion/config:/config, enabling the service to access the common configuration directory.

Let's verify the configuration directory structure: