Update docker img action version #94
Conversation
WalkthroughThe pull request updates the workflow configuration for building and publishing a ROS Docker image. The key modification is the upgrade of the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
.github/workflows/ros-docker-image.yaml(1 hunks)
🔇 Additional comments (1)
.github/workflows/ros-docker-image.yaml (1)
Line range hint 1-77: LGTM! The workflow configuration is well-structured.
The workflow maintains a clean and organized structure with:
- Proper matrix strategy for different platforms and Dockerfiles
- Clear input parameters with good descriptions
- Secure handling of DockerHub credentials
- Flexible support for both development and stable releases
🧰 Tools
🪛 actionlint (1.7.4)
58-58: the runner of "actions/checkout@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
| @@ -58,7 +58,7 @@ jobs: | |||
| uses: actions/checkout@v2 | |||
|
|
|||
| - name: Build Docker Image | |||
| uses: husarion-ci/ros-docker-img-action@v0.7 | |||
| uses: husarion-ci/ros-docker-img-action@v0.8 | |||
There was a problem hiding this comment.
💡 Codebase verification
Warning: The referenced version v0.8 does not exist and PR #4 is not merged
The verification reveals critical issues with this change:
- The PR Fix whitespace issues and double quotes in expr husarion-ci/ros-docker-img-action#4 is still open and not merged
- Version v0.8 is not available in the repository (latest is v0.7)
- Attempting to update to a non-existent version will cause workflow failures
This change should be reverted until the referenced PR is merged and v0.8 is properly released.
🔗 Analysis chain
Verify the action version update and its implications.
The update from v0.7 to v0.8 aims to address failing builds. Let's verify this change:
Please ensure:
- The referenced PR (Fix whitespace issues and double quotes in expr husarion-ci/ros-docker-img-action#4) is merged
- Version v0.8 is stable and contains the necessary fixes
- There are no breaking changes in the action's inputs
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the action version and referenced PR
# Check if the referenced PR is merged and the tag exists
gh api repos/husarion-ci/ros-docker-img-action/pulls/4 --jq '.merged, .state'
# Check available versions/tags
gh api repos/husarion-ci/ros-docker-img-action/tags --jq '.[].name'
# Check for breaking changes by comparing action.yml between versions
gh api repos/husarion-ci/ros-docker-img-action/contents/action.yml?ref=v0.7 --jq '.content' | base64 -d > v0.7_action.yml
gh api repos/husarion-ci/ros-docker-img-action/contents/action.yml?ref=v0.8 --jq '.content' | base64 -d > v0.8_action.yml
diff v0.7_action.yml v0.8_action.yml || true
Length of output: 642
Summary
Bumps
ros-docker-img-actionversion fixing failing builds. More information: husarion-ci/ros-docker-img-action#4Summary by CodeRabbit