-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ros2 docking tf compare #451
Conversation
Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Co-authored-by: Rafal Gorecki <126687345+rafal-gorecki@users.noreply.github.com>
Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
…s2-docking-tf-compare
* added half tested panther_docking package Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Added tests Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Added redme Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * run precommit Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Fix typo Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * After coderabbit review Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * fixed parameters | fixed exporting_package Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Adjust cmake Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Added getParameters and declareParameters | review suggestions Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * added offsetPose | moved transformPose to ros_utils Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * removed hardware deps Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Moved TransformPose to tf2_utils Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * added filter description Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * removed realtime_tools Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Modef OffsetFunction utils Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * added and applied ArePosesNear() Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * fix tf utils header guard Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Added comment Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Added locking node Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Update docking to develop (#399) * Implement testing POC * Namespace refactor * Add EStop to Gazebo * unify CMakeLists.txt files * Add dependencies * Add remapping * Rename files in panther_diagnostics package * Update after changes in panther_diagnostics * Rename config and launch file in manager package * Correct include guards in manager package * Restructure files tree in manager tests * Ros2 estop sim gui (#384) * New format of documentation (#369) * Change 3 package for demo * Improve ROS_API * fix links * Update * Update * Table improvements * Format * Save work * Save work * update * fix * fix * fix * fix * fix * Add API warning * Improve links * lights simplify * Create CONFIGURATION.md files * Typos * pre-commit * Apply suggestions from code review Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Save work * Final unification * Delete trash * typos * Update README.md * Update ROS_API.md * Update ROS_API.md * Update README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Change initial warning to beta warning * improve warn rendering * rendering * Update Diagram * Add Dawid suggestions * Dot * Change diagram ext and typos * Do not describe external nodes * Add Dawid suggestons * Add last Dawid suggestions * Format * Pawel suggestions * Diagram improvements * Update * Diagram Visual --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Change scheme theme (#380) * unify CMakeLists.txt files (#381) * First working version * Ros2 increase bt service timeout (#382) * Parametrize and increase service timeout in managers * Format panther API drawio file * Add Estop GUI and docs --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Paweł Irzyk <108666440+pawelirh@users.noreply.github.com> Co-authored-by: Dawid Kmak <73443304+KmakD@users.noreply.github.com> * Update panther_gazebo/panther_hardware_plugins.xml Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Add david suggestion and change gui layout * Typos in Readme + estop publish on service call * Reorganize files in panther_lights * UPdate include guards in panther_lights * Reorganize files in panther_battery * Move estop to plugins folder * add nmea gps * Rename battery driver files * Rename shutdown hosts config * Inherit from IgnitionSystem * Change to Estop -> EStop * Reorganize panther_hardware_interfaces files * Dawid suggestions part 1 * Rename PantherSystem -> GzPantherSystem * Update references to files * Rename battery exec * Fix links in documentations (#387) * Refer to header files * Update panther_gazebo/include/panther_gazebo/gz_panther_system.hpp Co-authored-by: Dawid Kmak <73443304+KmakD@users.noreply.github.com> * Update panther_gazebo/src/gz_panther_system.cpp Co-authored-by: Dawid Kmak <73443304+KmakD@users.noreply.github.com> * Update panther_gazebo/src/gz_panther_system.cpp Co-authored-by: Dawid Kmak <73443304+KmakD@users.noreply.github.com> * Dawid suggestions * delete typo * Minor modifications * Move BT plugins to src directory * Reorganize test utilities in hardware_interfaces * Merge remote-tracking branch 'origin/ros2-devel' into ros2-testing-poc * Add missing module configuration * Update panther_gazebo/include/panther_gazebo/gz_panther_system.hpp Co-authored-by: Dawid Kmak <73443304+KmakD@users.noreply.github.com> * Dawid suggestions * update docs * Extend filesystem responsibility * Update ROS_API.md Co-authored-by: Paweł Irzyk <108666440+pawelirh@users.noreply.github.com> * update names * Add new common utility functions * System monitor improvements * Round temperature precision * Implement filesystem unit tests * Formatting * Add integration tests condition * Update ROS_API.md * Review changes * Add pre-commit workflow (#395) --------- Co-authored-by: pawelirh <pawel.irzyk@husarion.com> Co-authored-by: rafal-gorecki <rafal.gorecki@husarion.com> Co-authored-by: Dawid <kmakd197@gmail.com> Co-authored-by: rafal-gorecki <126687345+rafal-gorecki@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Paweł Irzyk <108666440+pawelirh@users.noreply.github.com> Co-authored-by: Dawid Kmak <73443304+KmakD@users.noreply.github.com> * ROS2 docking manager plugins (#394) * Added base of BT docking plugins Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Teste dock and undock plugins Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Removed test dock manager Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * run precommit Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * moved plugins Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * changed names of files and classes | changed DockRobotAction to DockRobot Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Fixed copyright Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Changed timeouts | changed using Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> --------- Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * JoySubscription BT node (#397) * changed main in manager's tests Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Changed to AreButtonsPressed Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> --------- Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Fixed model Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Revert "Fixed model" This reverts commit 97d85c2. * Fixed model Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Readme update Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Update panther_docking/README.md Co-authored-by: Paweł Irzyk <108666440+pawelirh@users.noreply.github.com> * Added exec depend and pip install to cmake Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * add python as interpreter Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Fixed namespaces and updated ros_component_description (#424) * Fixed namespaces and updated ros_component_description Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Remove panther_version --------- Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> Co-authored-by: rafal-gorecki <rafal.gorecki@husarion.com> * Ros2 docking manager no lights (#430) * Manage lights * Simple working version * Clean up * Clean up and add types enums * Simplifications * Change ports * Add use_docking arg * Fix port * Fix port * Add more cases to tests * update * Fix ports * Add dock_pose field, improve description, add dependencies * Docking manager without lights * Auto review * Update CONFIGURATION.md * Typo * Coderabbit suggestions * Jakub suggestions * Fix tests * Jakub suggestions * ROS2 docking fix joy (#439) * Fixed utils test, fixed joy Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Revert "Fixed utils test, fixed joy" This reverts commit 3bd5e30. * Fixed bt utils test, changed dock jot input Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Joy input and typo Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> --------- Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Charging Dock Plugin based on dock pose subscriber (#431) * Fixed namespaces and updated ros_component_description Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Changed GetDockPose approach Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Cleanup charger Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Added unit tests Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Update docs: Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Fix upside down Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Added updateAndPublishStagingPose method Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Added suggestins | added reading docking_server parameter is dock pose publisher Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Remove redundant tests Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Added aprilros launch to simulation Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * update vsc and changed dock name Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> --------- Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Ros2 docking charging dock wibotic msgs (#436) * Fixed namespaces and updated ros_component_description Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Changed GetDockPose approach Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Cleanup charger Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Added unit tests Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Update docs: Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Fix upside down Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Added updateAndPublishStagingPose method Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Added suggestins | added reading docking_server parameter is dock pose publisher Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Remove redundant tests Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Added reading wibotic_info Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Added launching wibotic_connector_can Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Added right condition to wibotic_connector_can Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * wibotic_ros is needed to build Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Update repose, update parameters Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Added condition for use_docking Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * update repose Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Fixed use_wibotic_info param Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Rafal's suggestions applied Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * README update and comment delete Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Update docs Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Update .repose Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> --------- Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * ROS2 docking nav2 (#443) * Fixed namespaces and updated ros_component_description Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Changed GetDockPose approach Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Cleanup charger Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Added unit tests Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Update docs: Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Fix upside down Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Added updateAndPublishStagingPose method Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Added suggestins | added reading docking_server parameter is dock pose publisher Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Remove redundant tests Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Added aprilros launch to simulation Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * update vsc and changed dock name Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Tested with nav2 in simulation | Added docking to multibple stations | Spawning multiple stations Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Fixed after merge Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * described parameters | applied codeguides Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * coderabbitai suggestions Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Review Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * wibotic_connector_ros depends on hardware | fixed launch args Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * wibotic_connector_ros depends on hardware | fixed launch args Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Added default values Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Update panther_manager/launch/manager.launch.py --------- Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> Co-authored-by: Rafal Gorecki <126687345+rafal-gorecki@users.noreply.github.com> * Ros2 docking tf compare (#451) * Changed camera pose Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Fixed test Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Update docs Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * typo Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * typo Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Update panther_docking/README.md Co-authored-by: Rafal Gorecki <126687345+rafal-gorecki@users.noreply.github.com> * updated vcs Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> --------- Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> Co-authored-by: Rafal Gorecki <126687345+rafal-gorecki@users.noreply.github.com> * Ros2 docking lifecycle node (#453) * Changed camera pose Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Fixed test Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Update docs Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * typo Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * typo Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Changed to lifecyclenode | added transition service client Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Updated docs Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Added timeout function Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> --------- Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Changed names in package Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Revert "Changed names in package" This reverts commit 31ae7ce. * ROS2 Docking - panther_docking to husarion_ugv_docking (#459) * Changed names in package Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * fixed param name Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> --------- Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Removed docking Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Removed docking manager Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Removed docking manager Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Fixed after merge Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Code rabbit ai suggestions Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Remove accident panther_manager Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Removed dock plugins Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Fixed path Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Fixed path Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Fixed path Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Removed docking files Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Removed tf2_utils Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * removed station launch Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Fixed HEADER GUARD Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> --------- Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> Co-authored-by: pawelirh <pawel.irzyk@husarion.com> Co-authored-by: rafal-gorecki <rafal.gorecki@husarion.com> Co-authored-by: Dawid <kmakd197@gmail.com> Co-authored-by: rafal-gorecki <126687345+rafal-gorecki@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Paweł Irzyk <108666440+pawelirh@users.noreply.github.com> Co-authored-by: Dawid Kmak <73443304+KmakD@users.noreply.github.com>
Description
wibotic_receiver_link
Requirements
Tests 🧪