Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added exporting include manager #464

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Added exporting include manager #464

merged 1 commit into from
Dec 12, 2024

Conversation

delihus
Copy link
Contributor

@delihus delihus commented Dec 12, 2024

Description

Added exporting include folder in the manager

Requirements

  • Code style guidelines followed
  • Documentation updated

Tests 🧪

  • Robot
  • Container
  • Simulation

Summary by CodeRabbit

  • New Features
    • Added an export for include directories in the husarion_ugv_manager project, enhancing accessibility for dependent packages.

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
@delihus delihus requested a review from BOOTCFG December 12, 2024 13:14
Copy link
Contributor

coderabbitai bot commented Dec 12, 2024

Walkthrough

The changes in this pull request involve the addition of a new line in the CMakeLists.txt file for the husarion_ugv_manager project. This line, ament_export_include_directories(include), is intended to export the include directories, making them accessible to other packages that depend on husarion_ugv_manager. No other changes to the logic or control flow are present.

Changes

File Path Change Summary
husarion_ugv_manager/CMakeLists.txt Added ament_export_include_directories(include) to export the include directory.

Possibly related PRs

  • Ros2 bt manager to hpp #461: This PR modifies the CMakeLists.txt file for the husarion_ugv_manager project, which is directly related to the changes made in the main PR that also involves modifications to the same file.

Suggested reviewers

  • rafal-gorecki

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bdbfd7f and 5c3e455.

📒 Files selected for processing (1)
  • husarion_ugv_manager/CMakeLists.txt (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • husarion_ugv_manager/CMakeLists.txt

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@delihus delihus merged commit 0ec21ac into ros2-devel Dec 12, 2024
1 check passed
@delihus delihus deleted the ros2-fix-manager branch December 12, 2024 13:48
@coderabbitai coderabbitai bot mentioned this pull request Dec 12, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants