Control the selection and sort

[severo]

Add four props to control the selection and the sort: selection, onSelectionChange, orderBy and onOrderByChange.

See how we use it in an app: https://github.com/hyparam/hyperparam-cli/pull/139/files

Replaces #21, since having a reducer depending on props seems to be a bad practice.

Note that it removes the need for tableControl (I removed it).

[severo]

Update:

I removed selection and anchor from the internal state in ControlledHighTable and replaced them with two props: selectionAndAnchor and setSelectionAndAnchor.

In HighTable, I handle the selection and anchor in the reduced state, but I added an optional callback onSelectionChange to provide the value to the parent (while not providing a way to set the selection).

---

edit: oops, I broke the tests, I'll update on Monday

[platypii]

I think it's generally heading in the right direction with SelectionAndAnchor stuff.

I'm a little suspicious about exposing the state and dispatch as props which are meant to be InternalActions but actually leak out.

Specifically orderBy needs to be settable from outside the component, and I see in the demo that you do a dispatch with an "internal" SET_ORDER message. This works but feels weird. I think ideally there would be no state and dispatch exposed as props, and instead have orderBy and setOrderBy managed by the parent?

Alternatively there could be an ExternalState type with both selectionAndAnchor and also orderBy?

I feel like the ideal world is that InternalState is managed by an internal reducer that doesn't need to be exposed. We hoist only the state and setters needed as props to expose to the parent.

The thing I am worried about is losing the benefits of a reducer of doing predictable atomic state updates. For example: if we need to clear the selection when orderBy changes, does the parent component need to sync two useStates? Or is there an InternalReducer in HighTable and also be an ExternalReducer in the parent component which receives ExternalAction and updates the ExternalState accordingly?

[severo]

Re orderBy: indeed, I only did the change for selection, but not for order yet, so the current state is a weird mix.

But I also agree that the reducer is useful when a change in one property has consequences on the other ones (order by resets the selection for example). And I'm not sure yet how to handle it best.

[platypii]

Solid refactoring, with much more clear, typesafe, and flexible API! Using hooks does seem like the right choice here. Thanks for fighting through this I'm sure this was not easy to get right.