-
Notifications
You must be signed in to change notification settings - Fork 3
Control the selection and sort #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 26 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
a200d8a
add setSelection to tableControl + add onOrderByChange and onSelectio…
severo bd09f5f
publish two components: HighTable and ControlledHighTable
severo eb5c85a
add missing export
severo 960ae90
add tests
severo f177d37
replace selection in state by onSelectionChange for HighTable
severo 6aa002d
format
severo db88dc9
apply React logic to HighTable selection
severo 5d3b876
apply the same logic for orderBy / onOrderByChange
severo 65e7911
remove orderBy and selection from the shared state
severo 1654458
move state to ControlledHighTable
severo fcee341
remove intermediate ControlledHighTable
severo cc1bc00
add tests and fix bugs
severo 7396902
remove useEffect and avoid calling onSelectionAndAnchorChange on moun…
severo 6aea297
rename selectionAndAnchor to selection for simplicity
severo acb21f3
remove outdated comment
severo 27252d2
add role to help accessibility and selectors in tests
severo 95b67b5
add tests
severo 50bc65b
add tests for mode 3
severo a4c501b
add tests for mode 4
severo 063babe
add tests to show that selected prop cannot be defined/undefined afte…
severo 312cec8
extract common code to useControlleableState custom hook
severo 315e238
rename the hook useInputState, and add tests
severo 4544727
update text in test
severo 0392bf3
add README + default property to OrderBy
severo ae9da2a
fix css
severo 2abb7d2
fix corner checkbox
severo 73b3708
remove unneeded sort.ts file
severo 2da4a38
replace fireEvent with userEvent where possible
severo 137f365
fix OrderBy import/export
severo 28a4256
hoist data and otherData
severo 29ccfde
formatting
severo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.