Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest OpenZeppelin base contracts #149

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

awrichar
Copy link
Contributor

@awrichar awrichar commented Mar 4, 2024

There is no change to the external function signatures, but this brings us inline with the latest ERC20/ERC721 examples from OpenZeppelin.

ERC721WithData now extends ERC721URIStorage for token URI functionality. There is one slight change in behavior: if you specify a "base URI", then individual token URIs are always understood to be a suffix for that base URI. The previous contract would ignore the base URI when a token URI was specified.

Old contracts will be unchanged, and no functionality in the connector or FireFly will be changed by this new behavior - but users of the contract will need to plan accordingly for how they specify base URI and token URIs.

Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
This makes the contracts more consistent with OpenZeppelin examples. No
signatures are changed, but there is one slight change in behavior: if
you specify a "base URI", then individual token URIs are always
understood to be a suffix for that base URI. The previous contract
would ignore the base URI when a token URI was specified.

Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
@nguyer nguyer merged commit a90c44b into hyperledger:main Mar 4, 2024
4 checks passed
@awrichar awrichar deleted the contracts branch March 4, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants