Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALTAPPS-1277: Shared, Android new first session onboarding #1080

Conversation

XanderZhu
Copy link
Contributor

@XanderZhu XanderZhu commented Jun 12, 2024

YouTrack Issues:
ALTAPPS-1277

Checklist

Before Code Review:

  • Fields "Assignees, Labels, Milestone" are filled in the pull request;
  • Sentry Performance Monitoring of screen loading is added for new screens;
  • View analytics events are added for new screens;
  • New analytics events are documented;
  • All checks have been passed;
  • Changes have been checked locally.

Description

  • Rename old AppFeature & WelcomeOnboardingFeature to LegacyAppfeature
    & LegacyWelcomeOnboardingFeature to continue use on the iOS side;
  • Implement new AppFeature without old welcome onboarding;
  • Implement new WelcomeOnboardingFeature.

@XanderZhu XanderZhu self-assigned this Jun 12, 2024
@github-actions github-actions bot added shared Shared module task ios iOS module task android Android module task labels Jun 12, 2024
@XanderZhu XanderZhu added this to the 1.61 milestone Jun 12, 2024
@XanderZhu XanderZhu marked this pull request as ready for review June 18, 2024 13:06
@XanderZhu XanderZhu added the awaiting review Pull Request is awaiting code reviews label Jun 18, 2024
…irst-session-onboarding

# Conflicts:
#	shared/src/commonMain/kotlin/org/hyperskill/app/users_questionnaire_onboarding_legacy/injection/UsersQuestionnaireOnboardingFeatureBuilder.kt
#	shared/src/commonMain/kotlin/org/hyperskill/app/users_questionnaire_onboarding_legacy/presentation/LegacyUsersQuestionnaireOnboardingActionDispatcher.kt
@ivan-magda ivan-magda self-requested a review June 19, 2024 05:09
@ivan-magda ivan-magda removed the awaiting review Pull Request is awaiting code reviews label Jun 19, 2024
@ivan-magda ivan-magda changed the title ALTAPPS-1277: Shared android new first session onboarding ALTAPPS-1277: Shared, Android new first session onboarding Jun 19, 2024
@ivan-magda ivan-magda merged commit 8d5653d into develop Jun 19, 2024
13 checks passed
@ivan-magda ivan-magda deleted the feature/ALTAPPS-1277/Shared-android-new-first-session-onboarding branch June 19, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android Android module task ios iOS module task shared Shared module task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants