-
Notifications
You must be signed in to change notification settings - Fork 12
ALTAPPS-1277: Shared, Android new first session onboarding #1080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ivan-magda
merged 39 commits into
develop
from
feature/ALTAPPS-1277/Shared-android-new-first-session-onboarding
Jun 19, 2024
Merged
Changes from 16 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
d7d3a76
Rename WelcomeOnboardingFeature to LegacyWelcomeOnboardingFeature
XanderZhu 8aae7d7
Fix iOS build
XanderZhu 4a85f11
Rename welcome_onboarding package to legacy_welcome_onboarding
XanderZhu a31c56c
Add appFeature copy without child LegacyWelcomeOnboardingFeature; Use…
XanderZhu 3a055e8
Use LegacyMainComponent on iOS
XanderZhu b2a93f3
Implement new WelcomeOnboardingFeature frame
XanderZhu 2cd933f
Merge branch 'develop' into feature/ALTAPPS-1277/Shared-android-new-f…
XanderZhu 7f5cc7e
Implement WelcomeOnboardingEntryPoint
XanderZhu f132998
Fix detekt
XanderZhu 1562e1a
Navigate user to study plan after auth if track is selected & notific…
XanderZhu 4909a1c
Rename WelcomeOnboardingStartingScreen to WelcomeOnboardingEntryPoint
XanderZhu c98d3ff
Rename UsersQuestionnaireOnboardingFeature to LegacyUsersQuestionnair…
XanderZhu 8c5d006
Pass params to WelcomeOnboardingFeature
XanderZhu 2d70743
Implement welcome questionnaire
XanderZhu 2532cb6
Implement language selection
XanderZhu d949c12
Implement track screen
XanderZhu 49c2d3e
Implement track selection
XanderZhu 7efd693
Refactor packages
XanderZhu 4074a79
Add WelcomeOnboardingFeature to new onboarding flow
XanderZhu dbeb117
Implement nextLearningActivity fetch
XanderZhu 27bbada
Implement WelcomeOnboardingFinishFragment
XanderZhu cca2f6e
Implement WelcomeOnboarding completion
XanderZhu 25f10a7
Implement WelcomeOnboardingFinishComponent
XanderZhu df7d486
Implement WelcomeOnboarding flow launch for user with selected track
XanderZhu 4b6365d
Merge branch 'develop' into feature/ALTAPPS-1277/Shared-android-new-f…
XanderZhu 6a714ae
Show NextLearningActivityLoading
XanderZhu 3edab71
Cleanup
XanderZhu a2ab508
Cleanup
XanderZhu 9addeae
Add analytic events
XanderZhu 99573fb
Fix NotificationOnboarding condition after track selection
XanderZhu 63855fd
Fix detekt & ktlint
XanderZhu 72adb0e
Refactor shared packages
XanderZhu d558130
Merge branch 'develop' into feature/ALTAPPS-1277/Shared-android-new-f…
XanderZhu 116ba16
Fix ktlint
XanderZhu af39ef7
Fix iOS build
XanderZhu 5feb6d8
Merge branch 'develop' into feature/ALTAPPS-1277/Shared-android-new-f…
XanderZhu 7dd374a
Use new analytic logging approach
XanderZhu c2bdaf0
iOS: Fix build
ivan-magda 65c4161
Apply suggestions from code review
ivan-magda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 37 additions & 0 deletions
37
...hyperskill/app/android/welcome_onbaording/fragment/WelcomeOnboardingEntryPointFragment.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
package org.hyperskill.app.android.welcome_onbaording.fragment | ||
|
||
import android.os.Bundle | ||
import android.view.LayoutInflater | ||
import android.view.View | ||
import android.view.ViewGroup | ||
import androidx.compose.ui.platform.ComposeView | ||
import androidx.compose.ui.platform.ViewCompositionStrategy | ||
import androidx.fragment.app.Fragment | ||
import org.hyperskill.app.android.core.view.ui.widget.compose.HyperskillTheme | ||
import org.hyperskill.app.android.welcome_onbaording.model.WelcomeOnboardingHost | ||
import org.hyperskill.app.android.welcome_onbaording.ui.WelcomeOnboardingEntryPoint | ||
|
||
class WelcomeOnboardingEntryPointFragment : Fragment() { | ||
companion object { | ||
fun newInstance(): WelcomeOnboardingEntryPointFragment = | ||
WelcomeOnboardingEntryPointFragment() | ||
} | ||
|
||
override fun onCreateView( | ||
inflater: LayoutInflater, | ||
container: ViewGroup?, | ||
savedInstanceState: Bundle? | ||
): View = | ||
ComposeView(requireContext()).apply { | ||
setViewCompositionStrategy(ViewCompositionStrategy.DisposeOnLifecycleDestroyed(viewLifecycleOwner)) | ||
setContent { | ||
HyperskillTheme { | ||
WelcomeOnboardingEntryPoint(onStartClick = ::onStartClick) | ||
} | ||
} | ||
} | ||
|
||
private fun onStartClick() { | ||
(parentFragment as? WelcomeOnboardingHost)?.onStartClick() | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.