Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue1935_unprotect dh and change prefixes to input #1936

Merged
merged 6 commits into from
Nov 4, 2024

Conversation

kldjonge
Copy link
Contributor

@kldjonge kldjonge commented Oct 4, 2024

unprotect dh and change prefixes to input to hide it from the dialog box

This closes #1935

unprotect dh and change prefixes to input to hide it from the dialog box
@kldjonge kldjonge changed the title unprotect dh and change prefixes to input Issue1935_unprotect dh and change prefixes to input Oct 4, 2024
@kldjonge kldjonge requested a review from mwetter October 4, 2024 13:43
Copy link
Contributor

@mwetter mwetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add revision notes, otherwise it looks good provided the tests for lbl-srg/modelica-buildings#4021 run. If they fail we will need to see why.

@mwetter
Copy link
Contributor

mwetter commented Oct 25, 2024

@kldjonge : can you please add the missing revision notes so we can complete this PR.

@mwetter mwetter merged commit 1b514c2 into master Nov 4, 2024
3 checks passed
@mwetter mwetter deleted the issues1935_unprotectdhDiscretizedDoor branch November 4, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unprotect dh in IBPSA.Airflow.Multizone.BaseClasses.DoorDiscretized
2 participants