Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue1935_unprotect dh and change prefixes to input #1936

Merged
merged 6 commits into from
Nov 4, 2024
Merged

Issue1935_unprotect dh and change prefixes to input #1936

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
82250ce
unprotect dh and change prefixes to input
kldjonge Oct 4, 2024
6701fab
Merge branch 'master' into issues1935_unprotectdhDiscretizedDoor
mwetter Oct 17, 2024
dcc8a90
Merge branch 'master' into issues1935_unprotectdhDiscretizedDoor
mwetter Oct 25, 2024
3c187e7
Revision note for DoorDiscretized.mo
kldjonge Oct 29, 2024
efa01d6
Merge branch 'master' into issues1935_unprotectdhDiscretizedDoor
mwetter Oct 30, 2024
0ab551c
Corrected long line
mwetter Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions IBPSA/Airflow/Multizone/BaseClasses/DoorDiscretized.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ partial model DoorDiscretized
Modelica.Units.SI.Velocity vTop "Velocity at top of opening from A to B";
Modelica.Units.SI.Velocity vBot "Velocity at bottom of opening from A to B";

protected
parameter Modelica.Units.SI.Length dh=hOpe/nCom "Height of each compartment";

input Modelica.Units.SI.Length dh=hOpe/nCom "Height of each compartment";
protected
parameter Medium.ThermodynamicState sta_default=Medium.setState_pTX(
T=Medium.T_default,
p=Medium.p_default,
Expand All @@ -28,11 +28,11 @@ protected
parameter Modelica.Units.SI.Density rho_default=Medium.density(sta_default)
"Density, used to compute fluid volume";

parameter Real hAg[nCom](each unit="m2/s2")=
input Real hAg[nCom](each unit="m2/s2")=
{Modelica.Constants.g_n*(hA - (i - 0.5)*dh) for i in 1:nCom}
"Product g*h_i for each compartment";

parameter Real hBg[nCom](each unit="m2/s2")=
input Real hBg[nCom](each unit="m2/s2")=
{Modelica.Constants.g_n*(hB - (i - 0.5)*dh) for i in 1:nCom}
"Product g*h_i for each compartment";
Modelica.Units.SI.AbsolutePressure pA[nCom](each nominal=101325)
Expand Down Expand Up @@ -118,6 +118,11 @@ using the model for a door that can be open or closed.
revisions="<html>
<ul>
<li>
October 29, 2024, by Klaas De Jonge:<br/>
Unprotected <code>dh</code> and changed prefixes of <code>dh</code>,<code>hAg</code> and <code>hBg</code> to <code>input</code>.<br/>
This is for <a href=\"https://github.com/ibpsa/modelica-ibpsa/issues/1935\">#1935</a>.
</li>
<li>
January 8, 2019, by Michael Wetter:<br/>
Moved parameter <code>CD</code> from
<a href=\"modelica://IBPSA.Airflow.Multizone.BaseClasses.DoorDiscretized\">
Expand Down
Loading