Update 2024 Winter Contents #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
2093ab
commented
Mar 12, 2024
2093ab
commented
- Update 2024 SUAPC
- Update 2024 Hall Of Fame
- Update Camp Contest not held
- Add Header backdrop-filter
witch-factory
approved these changes
Mar 12, 2024
| @@ -54,6 +54,7 @@ const Header = styled(({ className }) => { | |||
| </header> | |||
| ); | |||
| })` | |||
| backdrop-filter: blur(1.5rem); | |||
There was a problem hiding this comment.
어차피 이후 많은 수정이 있겠지만 이왕 헤더 바꾼거 글씨 크기도 조금만 키우죠. DesktopTopbarItem, MobileTopbarItem글씨 크기를 1rem으로 바꾸기만 하는 걸로...
pages/campcontest.page.js
Outdated
| title={"이번 시즌에는 Camp Contest가 진행되지 않았습니다"} | ||
| content={"다음 시즌을 기대해 주세요"} | ||
| /> | ||
| )} |
There was a problem hiding this comment.
그래도 지금 캠프 콘테스트 페이지에서 가장 먼저 보이는 게 2024 Winter일 텐데 콘테스트 일자, 소개, 출제경향은 남겨두는 게 좋지 않을까요? 콘테스트 일자에 이번 시즌에는 Camp Contest가 진행되지 않았습니다를 써두고 하단에 적당한 말 써두면 좋지 않을까 합니다.
| @@ -163,7 +163,7 @@ const Suapc = () => { | |||
| <ArchiveButton | |||
| disabled={!Boolean(currentSeasonData.fileNames.solutionPdf)} | |||
| href={ | |||
| (currentSeasonIdx !== 0 ? "https://api.suapc.kr/" : "/res/") + | |||
| (currentSeasonIdx > 1 ? "https://api.suapc.kr/" : "/res/") + | |||
There was a problem hiding this comment.
이건 지금 시즌에는 api를 이용해서 사진 가져오는 대신 public/res 폴더 사진 쓰려고 그런 게 맞죠?
There was a problem hiding this comment.
네넵 pdf랑 포스터를 서버에 못 올려둬서 일단 이렇게 바꿨어요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.