Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRE-208 - Adding additional outputs when setting prerelease input. #49

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

jsclifford
Copy link
Contributor

@jsclifford jsclifford commented Oct 14, 2024

Summary of PR changes

  • Adding the following outputs.
Output Description
NEXT_RELEASE_VERSION The next major.minor.patch release version. This version will not contain the branch when calculating a pre-release version.
NEXT_RELEASE_VERSON_NO_PREFIX The next major.minor.patch version without the tag prefix. This version will not contain the branch when calculating a pre-release version.

PR Requirements

  • For major, minor, or breaking changes, at least one of the commit messages contains the appropriate +semver: keywords.
    • See the Incrementing the Version section of the repository's README.md for more details.
  • The action code does not contain sensitive information.

NOTE: If the repo's workflow could not automatically update the README.md, it should be updated manually with the next version. For javascript actions, if the repo's workflow could not automatically recompile the action it should also be updated manually as part of the PR.

@jsclifford jsclifford requested a review from a team as a code owner October 14, 2024 22:32
Copy link

Before this PR can be merged, the following item(s) should be addressed to comply with the action's Contributing Guidelines.

  • Please update the action's version in the Usage Examples section of README.md. Each instance of this action should be updated to:
    uses: im-open/git-version-lite@v3.1.2
  • Please ensure the action has been recompiled by running the following command from the root of the repository:
    npm run build

Copy link
Contributor

@mike-schenk mike-schenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NEXT_MINOR_VERSION_NOLABEL and NEXT_MAJOR_VERSION_NOLABEL (and their *NO_PREFIX counterparts) are always equivalent to NEXT_MINOR_VERSION and NEXT_MAJOR_VERSION respectively. So those new outputs are unnecessary.

That just leaves NEXT_VERSION_NOLABEL. To match the previous output name format, it would be NEXT_VERSION_NO_LABEL and NEXT_VERSION_NO_LABEL_NO_PREFIX

However, the name NEXT_RELEASE_VERSION is probably even better because it indicates more what it is than what it's not.

@jsclifford
Copy link
Contributor Author

I am in the process of renaming to NEXT_RELEASE_VERSION. Thanks for helping me coin a more descriptive label

@jsclifford
Copy link
Contributor Author

@mike-schenk I have updated to address your required changes. Please review.

Copy link

Before this PR can be merged, the following item(s) should be addressed to comply with the action's Contributing Guidelines.

  • Please ensure the action has been recompiled by running the following command from the root of the repository:
    npm run build

mike-schenk
mike-schenk previously approved these changes Oct 17, 2024
Copy link

Before this PR can be merged, the following item(s) should be addressed to comply with the action's Contributing Guidelines.

  • Please update the action's version in the Usage Examples section of README.md. Each instance of this action should be updated to:
    uses: im-open/git-version-lite@v3.1.2

@jsclifford jsclifford force-pushed the SRE-208-Output-No-Pre-Release branch from 83be055 to 0ea69b8 Compare October 17, 2024 16:35
@cesar2532 cesar2532 merged commit f43e8a2 into main Oct 17, 2024
20 checks passed
@cesar2532 cesar2532 deleted the SRE-208-Output-No-Pre-Release branch October 17, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants