-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SRE-208 - Adding additional outputs when setting prerelease input. #49
Conversation
Before this PR can be merged, the following item(s) should be addressed to comply with the action's Contributing Guidelines.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NEXT_MINOR_VERSION_NOLABEL
and NEXT_MAJOR_VERSION_NOLABEL
(and their *NO_PREFIX
counterparts) are always equivalent to NEXT_MINOR_VERSION
and NEXT_MAJOR_VERSION
respectively. So those new outputs are unnecessary.
That just leaves NEXT_VERSION_NOLABEL
. To match the previous output name format, it would be NEXT_VERSION_NO_LABEL
and NEXT_VERSION_NO_LABEL_NO_PREFIX
However, the name NEXT_RELEASE_VERSION
is probably even better because it indicates more what it is than what it's not.
I am in the process of renaming to NEXT_RELEASE_VERSION. Thanks for helping me coin a more descriptive label |
@mike-schenk I have updated to address your required changes. Please review. |
Before this PR can be merged, the following item(s) should be addressed to comply with the action's Contributing Guidelines.
|
Before this PR can be merged, the following item(s) should be addressed to comply with the action's Contributing Guidelines.
|
83be055
to
0ea69b8
Compare
Summary of PR changes
NEXT_RELEASE_VERSION
major.minor.patch
release version. This version will not contain the branch when calculating a pre-release version.NEXT_RELEASE_VERSON_NO_PREFIX
major.minor.patch
version without the tag prefix. This version will not contain the branch when calculating a pre-release version.PR Requirements
+semver:
keywords.NOTE: If the repo's workflow could not automatically update the
README.md
, it should be updated manually with the next version. For javascript actions, if the repo's workflow could not automatically recompile the action it should also be updated manually as part of the PR.