-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require Faraday v2 #22
Conversation
@@ -341,6 +341,10 @@ def stub_api_request | |||
204 | |||
end | |||
|
|||
let(:response_hash) do | |||
nil | |||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Returns empty body response if 204 status code.
And, Qiita PUT
and DELETE
APIs return a empty body.
JSON Schema(en): https://qiita.com/api/v2/schema?locale=en
@nipe0324 |
e67e089
to
688bab4
Compare
@getty104 |
@nipe0324 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you for your contribution!
@@ -2,7 +2,6 @@ | |||
require "active_support/core_ext/string/inflections" | |||
require "active_support/core_ext/string/strip" | |||
require "faraday" | |||
require "faraday_middleware" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest Faraday version is v2. But, qiita-rb supports only v0.x.
I tried to change that qiita-rb requires Faraday v2.