Merge pull request #119 from razamiDev/ValidationReflectRemoval

Removed reflect usage from validation errors and updated tests. Breaking Change: 1. Use atlas-gentool v12.5 2. Update app to use lyft/protoc-gen-validate version 0.0.7 3. Override github.com/golang/protobuf to version 1.2.0
infobloxopen · Oct 12, 2018 · 0074c27 · 0074c27
2 parents 440f0df + e91ca3c
commit 0074c27
Show file tree

Hide file tree

Showing 7 changed files with 273 additions and 230 deletions.
diff --git a/Gopkg.lock b/Gopkg.lock
diff --git a/Gopkg.toml b/Gopkg.toml
@@ -18,9 +18,9 @@
   name = "github.com/grpc-ecosystem/grpc-gateway"
   version = "1.4.1"
 
-[[constraint]]
+[[override]]
   name = "github.com/lyft/protoc-gen-validate"
-  version = "0.0.5"
+  version = "0.0.7"
 
 [[constraint]]
   name = "github.com/sirupsen/logrus"

diff --git a/errors/mappers/validationerrors/README.md b/errors/mappers/validationerrors/README.md
@@ -87,7 +87,7 @@ Example Usage:
 			),
 			errors.MapFunc(func(ctx context.Context, err error) (error, bool) {
 				vErr, _ := err.(validationerrors.ValidationError)
-				return errors.NewContainer(codes.InvalidArgument, "Custom error message for field: %v reason: %v", vErr.Field, vErr.Reason), true
+				return errors.NewContainer(codes.InvalidArgument, "Custom error message for field: %v reason: %v", vErr.Field(), vErr.Reason()), true
             }),
        ),
     }