Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESIMD][NFC] Rename L3 cache hint parameters to L2 to avoid confusion #12862

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

v-klochkov
Copy link
Contributor

The experimental memory API used L3 to name the cache that always was L2 due to some historical reasons.
The new non-experimental API names the same cache level as L2.

This patch just renames the old L3 params to L2 to unify the naming in experimental and non-experimental namespaces and avoid the mess in cache names.

The experimental memory API used L3 to name the cache that always was L2
due to some historical reasons.
The new non-experimental API names the same cache level as L2.

This patch just renames the old L3 params to L2 to unify the naming in
experimental and non-experimental namespaces and avoid the mess in
cache names.

Signed-off-by: Klochkov, Vyacheslav N <vyacheslav.n.klochkov@intel.com>
@sarnex
Copy link
Contributor

sarnex commented Feb 29, 2024

Nit about the PR title: confuses -> confusion

@v-klochkov v-klochkov changed the title [ESIMD][NFC] Rename L3 cache hint parameters to L2 to avoid confuses [ESIMD][NFC] Rename L3 cache hint parameters to L2 to avoid confusion Feb 29, 2024
@v-klochkov
Copy link
Contributor Author

Fails on Windows task is seen in many other PRs. Here it is unrelated to this NFC change/PR.
Proceeding to merge.

@v-klochkov v-klochkov merged commit e151c5c into intel:sycl Feb 29, 2024
11 of 12 checks passed
@v-klochkov v-klochkov deleted the esimd_L3_to_L2_rename branch February 29, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants