[CI][SYCL] Enable E2E testing for New Offloading Model #20634

maksimsab · 2025-11-13T16:01:40Z

This patch has the following changes:

--param enable_new_offload_model is added to SYCL E2E LIT test configuration
NewOffloadModel mode run is added to sycl-linux-precommit
NewOffloadModel mode run is added to sycl-nightly for linux and windows.

.github/workflows/sycl-nightly.yml

YuriPlyakhin · 2025-11-26T19:29:24Z

@maksimsab , there are still some tests failing. Should they also be marked with XFAIL?

maksimsab · 2025-11-26T19:43:23Z

Update:

testing enabling depending on label is done.
SYCL :: AOT/multiple-devices.cpp is failing for linux GEN 12.
SYCL :: Basic/out_of_order_queue_status_ext_oneapi_empty.cpp is failing for linux GEN 12. Looks like a flaky test for now.
I still need to try to xfail some tests instead of unsupporting them.

sarnex

lgtm overall, minor comments. i wish we didn't have so much copy and paste but i dont have a better idea that's reasonable to implement

.github/workflows/sycl-nightly.yml

sycl/test-e2e/ESIMD/lit.local.cfg

aelovikov-intel · 2025-11-26T20:40:03Z

sycl/test-e2e/AOT/multiple-devices.cpp

 //===----------------------------------------------------------------------===//

+// XFAIL: new-offload-model
+// XFAIL-TRACKER: CMPLRLLVM-61170


For issues in this project public GH issue should be used. Internal bug trackers are only meaningful for issues in unrelated components because having GH issue here would provide no benefit.

aelovikov-intel · 2025-11-26T20:41:42Z

.github/workflows/sycl-linux-build.yml

+    - name: Remove E2E tests before NewOffloadModel run
+      if: ${{ inputs.e2e_binaries_new_offload_model_artifact && !cancelled() && steps.build.conclusion == 'success' }}
+      run: rm -rf build-e2e
+
+    - name: Build E2E tests with NewOffloadModel
+      if: |
+        inputs.e2e_binaries_new_offload_model_artifact &&
+        !cancelled()
+        && steps.build.conclusion == 'success' &&
+        contains(github.event.pull_request.labels.*.name, 'new-offload-model')
+      uses: ./devops/actions/run-tests/e2e
+      with:
+        ref: ${{ inputs.ref || github.sha }}
+        testing_mode: build-only
+        target_devices: all
+        binaries_artifact: ${{ inputs.e2e_binaries_new_offload_model_artifact }}
+        sycl_compiler: $GITHUB_WORKSPACE/toolchain/bin/clang++
+        extra_lit_opts: --param sycl_build_targets="spir;nvidia;amd" --param enable_new_offload_model=True


This is getting too verbose. Can we fold the removal into the devops/actions/run-tests/e2e and then use a matrix job to build all the flavors without that much copy-paste? That prerequisite refactoring should be done in a separate PR, obviously.

refactoring is posted here: #20790

aelovikov-intel · 2025-11-26T20:42:46Z

.github/workflows/sycl-linux-precommit.yml

+      packages: read
+    strategy:
+      fail-fast: false
+      matrix:


Isn't this a bit excessive? Do you really see value in running on all configurations?

That could be shrinked to intel only targets.

sycl/test-e2e/lit.cfg.py

aelovikov-intel · 2025-11-26T21:04:41Z

.github/workflows/sycl-nightly.yml

            target_devices: level_zero:gpu
            extra_lit_opts: --param test-preview-mode=True

+          - name: AMD/HIP with NewOffloadModel


Any chance https://docs.github.com/en/actions/how-tos/write-workflows/choose-what-workflows-do/run-job-variations#expanding-or-adding-matrix-configurations would help?

maksimsab had a problem deploying to WindowsCILock November 13, 2025 16:48 — with GitHub Actions Error

maksimsab had a problem deploying to WindowsCILock November 13, 2025 16:51 — with GitHub Actions Error

maksimsab had a problem deploying to WindowsCILock November 13, 2025 17:08 — with GitHub Actions Failure

maksimsab had a problem deploying to WindowsCILock November 13, 2025 17:35 — with GitHub Actions Failure

maksimsab had a problem deploying to WindowsCILock November 17, 2025 15:38 — with GitHub Actions Failure

maksimsab had a problem deploying to WindowsCILock November 17, 2025 15:39 — with GitHub Actions Failure

maksimsab had a problem deploying to WindowsCILock November 17, 2025 16:03 — with GitHub Actions Failure

maksimsab had a problem deploying to WindowsCILock November 17, 2025 16:05 — with GitHub Actions Failure

maksimsab had a problem deploying to WindowsCILock November 17, 2025 16:37 — with GitHub Actions Error

maksimsab had a problem deploying to WindowsCILock November 17, 2025 16:39 — with GitHub Actions Error

maksimsab had a problem deploying to WindowsCILock November 17, 2025 16:49 — with GitHub Actions Error

maksimsab had a problem deploying to WindowsCILock November 17, 2025 16:50 — with GitHub Actions Error

maksimsab had a problem deploying to WindowsCILock November 17, 2025 16:51 — with GitHub Actions Error

maksimsab had a problem deploying to WindowsCILock November 17, 2025 16:55 — with GitHub Actions Error

maksimsab had a problem deploying to WindowsCILock November 17, 2025 16:57 — with GitHub Actions Error

maksimsab had a problem deploying to WindowsCILock November 17, 2025 16:58 — with GitHub Actions Error

maksimsab temporarily deployed to WindowsCILock November 17, 2025 17:04 — with GitHub Actions Inactive

maksimsab had a problem deploying to WindowsCILock November 17, 2025 17:04 — with GitHub Actions Error

maksimsab had a problem deploying to WindowsCILock November 17, 2025 17:04 — with GitHub Actions Failure

github-advanced-security bot found potential problems Nov 17, 2025

View reviewed changes

.github/workflows/sycl-nightly.yml Fixed Show fixed Hide fixed

maksimsab temporarily deployed to WindowsCILock November 17, 2025 17:06 — with GitHub Actions Inactive

maksimsab had a problem deploying to WindowsCILock November 17, 2025 17:24 — with GitHub Actions Failure

maksimsab requested review from aelovikov-intel and sarnex November 26, 2025 19:20

maksimsab temporarily deployed to WindowsCILock November 26, 2025 19:21 — with GitHub Actions Inactive

maksimsab temporarily deployed to aws November 26, 2025 19:32 — with GitHub Actions Inactive

maksimsab temporarily deployed to WindowsCILock November 26, 2025 19:57 — with GitHub Actions Inactive

maksimsab had a problem deploying to WindowsCILock November 26, 2025 19:57 — with GitHub Actions Failure

maksimsab temporarily deployed to WindowsCILock November 26, 2025 19:57 — with GitHub Actions Inactive

maksimsab had a problem deploying to WindowsCILock November 26, 2025 19:57 — with GitHub Actions Failure

maksimsab temporarily deployed to WindowsCILock November 26, 2025 19:57 — with GitHub Actions Inactive

try xfail some tests

e3b2e53

maksimsab temporarily deployed to WindowsCILock November 26, 2025 19:58 — with GitHub Actions Inactive

maksimsab temporarily deployed to WindowsCILock November 26, 2025 20:24 — with GitHub Actions Inactive

sarnex approved these changes Nov 26, 2025

View reviewed changes

.github/workflows/sycl-nightly.yml Outdated Show resolved Hide resolved

sycl/test-e2e/ESIMD/lit.local.cfg Outdated Show resolved Hide resolved

aelovikov-intel reviewed Nov 26, 2025

View reviewed changes

remove xfail from test

0b42832

maksimsab temporarily deployed to WindowsCILock November 27, 2025 15:47 — with GitHub Actions Inactive

maksimsab temporarily deployed to WindowsCILock November 27, 2025 16:15 — with GitHub Actions Inactive

maksimsab added 2 commits November 28, 2025 08:24

mark test as unsupported

ca46e05

Merge branch 'sycl' into enable_e2e_testing_new_offload

ce7dbcd

maksimsab temporarily deployed to WindowsCILock November 28, 2025 16:25 — with GitHub Actions Inactive

maksimsab had a problem deploying to WindowsCILock November 28, 2025 16:51 — with GitHub Actions Failure

remove too verbose settings. remove AMD/NVIDIA runs from nightly

9f635ba

maksimsab had a problem deploying to WindowsCILock December 1, 2025 14:54 — with GitHub Actions Failure

maksimsab had a problem deploying to WindowsCILock December 1, 2025 15:21 — with GitHub Actions Failure

maksimsab mentioned this pull request Dec 1, 2025

[CI] Refactor cleanup of built E2E tests in precommit and use matrix for E2E building. #20790

Open

[CI][SYCL] Enable E2E testing for New Offloading Model #20634

Are you sure you want to change the base?

[CI][SYCL] Enable E2E testing for New Offloading Model #20634

Uh oh!

Conversation

maksimsab commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

YuriPlyakhin commented Nov 26, 2025

Uh oh!

maksimsab commented Nov 26, 2025

Uh oh!

sarnex left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

aelovikov-intel Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

aelovikov-intel Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maksimsab Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

aelovikov-intel Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

maksimsab Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aelovikov-intel Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

maksimsab Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

maksimsab commented Nov 13, 2025 •

edited

Loading

aelovikov-intel Nov 26, 2025 •

edited

Loading

maksimsab Dec 1, 2025 •

edited

Loading