-
Notifications
You must be signed in to change notification settings - Fork 798
[CI] Refactor cleanup of built E2E tests in precommit and use matrix for E2E building. #20790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: sycl
Are you sure you want to change the base?
Conversation
aelovikov-intel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My original suggestion was to do this plus merge all E2E jobs in sycl-linux-build.yml` into a matrix job. I'm not sure if you're doing that in two PRs or missed the latter part of the suggestion.
|
I missed the part about building tests in a matrix. This also is a good idea. |
|
@aelovikov-intel I found out that this is inappropriate for job's matrix to conditionally exclude elements. But we should do it when binaries_artifact inputs are not provided. I can either make a separate job that prepares a matrix by shell or I can leave it as is. |
Doesn't llvm/.github/workflows/sycl-linux-run-tests.yml Lines 93 to 96 in 4b4d451
llvm/.github/workflows/sycl-linux-precommit.yml Lines 193 to 207 in 4b4d451
|
This change approaches the feedback from #20634 related to repeated cleanup.