Skip to content

Conversation

@maksimsab
Copy link
Contributor

@maksimsab maksimsab commented Dec 1, 2025

This change approaches the feedback from #20634 related to repeated cleanup.

Copy link
Contributor

@aelovikov-intel aelovikov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My original suggestion was to do this plus merge all E2E jobs in sycl-linux-build.yml` into a matrix job. I'm not sure if you're doing that in two PRs or missed the latter part of the suggestion.

@maksimsab
Copy link
Contributor Author

I missed the part about building tests in a matrix. This also is a good idea.

@maksimsab maksimsab changed the title [CI] Refactor cleanup of built E2E tests in precommit [CI] Refactor cleanup of built E2E tests in precommit and use matrix for E2E building. Dec 1, 2025
@maksimsab
Copy link
Contributor Author

@aelovikov-intel I found out that this is inappropriate for job's matrix to conditionally exclude elements. But we should do it when binaries_artifact inputs are not provided.

I can either make a separate job that prepares a matrix by shell or I can leave it as is.

@aelovikov-intel
Copy link
Contributor

aelovikov-intel commented Dec 1, 2025

@aelovikov-intel I found out that this is inappropriate for job's matrix to conditionally exclude elements. But we should do it when binaries_artifact inputs are not provided.

I can either make a separate job that prepares a matrix by shell or I can leave it as is.

Doesn't

skip_run:
type: string
default: 'false'
required: False
help with that? We use it here:
# We're in an ABI-breaking window, so these don't make sense for now.
- name: ABI compatibility / sycl-rel-6_2
runner: '["Linux", "pvc"]'
image: ghcr.io/intel/llvm/sycl_prebuilt_tests:sycl-rel-6_2
target_devices: level_zero:gpu
extra_lit_opts: '--param test-preview-mode=False --filter-out "${{ needs.compat_read_exclude.outputs.FILTER_6_2 }}"'
binaries_artifact: 'in-container'
skip_run: true
- name: ABI compatibility / sycl-rel-6_3
runner: '["Linux", "pvc"]'
image: ghcr.io/intel/llvm/sycl_prebuilt_tests:sycl-rel-6_3
target_devices: level_zero:gpu
extra_lit_opts: '--param test-preview-mode=False --filter-out "${{ needs.compat_read_exclude.outputs.FILTER_6_3 }}"'
binaries_artifact: 'in-container'
skip_run: true

@maksimsab maksimsab deployed to WindowsCILock December 1, 2025 18:27 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants