-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid Module creation for Constant Gate scenarios #481
Open
mjayasim9
wants to merge
13
commits into
intel:main
Choose a base branch
from
mjayasim9:ConstGates
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
292bf2d
Avoid Module creation for Constant Gate scenarios
mjayasim9 81734f2
Removed extra import
mjayasim9 efa4b95
Added changes based on comments
mjayasim9 7a3974a
Merge branch 'main' of https://github.com/mjayasim9/rohd into ConstGates
mjayasim9 cbf0c26
Merge branch 'intel:main' into ConstGates
mjayasim9 8e7789b
Added fixes based on feedback
mjayasim9 abb0d87
Merge branch 'main' of https://github.com/mjayasim9/rohd into ConstGates
mjayasim9 4393d10
Merge branch 'ConstGates' of https://github.com/mjayasim9/rohd into C…
mjayasim9 33faf6e
Merge branch 'main' of https://github.com/mjayasim9/rohd into ConstGates
mjayasim9 7862a94
Merge branch 'intel:main' into ConstGates
mjayasim9 afc42b6
Merge branch 'main' of https://github.com/mjayasim9/rohd into ConstGates
mjayasim9 7ba4e11
Avoid module creation for Const gate scenarios
mjayasim9 972c211
Merge branch 'ConstGates' of https://github.com/mjayasim9/rohd into C…
mjayasim9 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upon review, I realized that perhaps operators could be overridden on
Const
class instead of these special cases here.For example:
Then in
Const
you can just override@override Logic operator &(Logic other)
to perform the const version of things.