Skip to content

New precheck procedure to enhance stability. #1453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Feb 8, 2025

Merge branch 'master' into new_precheck_procedure

54d489c
Select commit
Loading
Failed to load commit list.
Merged

New precheck procedure to enhance stability. #1453

Merge branch 'master' into new_precheck_procedure
54d489c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Feb 7, 2025 in 0s

91.32% of diff hit (target 85.00%)

View this Pull Request on Codecov

91.32% of diff hit (target 85.00%)

Annotations

Check warning on line 456 in dlrover/python/elastic_agent/master_client.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

dlrover/python/elastic_agent/master_client.py#L454-L456 

Added lines #L454 - L456 were not covered by tests

Check warning on line 28 in dlrover/python/master/args.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

dlrover/python/master/args.py#L28 

Added line #L28 was not covered by tests

Check warning on line 48 in dlrover/python/master/diagnosis/diagnosis.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

dlrover/python/master/diagnosis/diagnosis.py#L48 

Added line #L48 was not covered by tests

Check warning on line 89 in dlrover/python/master/diagnosis/diagnosis_manager.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

dlrover/python/master/diagnosis/diagnosis_manager.py#L89 

Added line #L89 was not covered by tests

Check warning on line 128 in dlrover/python/master/diagnosis/diagnosis_manager.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

dlrover/python/master/diagnosis/diagnosis_manager.py#L126-L128 

Added lines #L126 - L128 were not covered by tests

Check warning on line 61 in dlrover/python/master/diagnosis/precheck_operator.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

dlrover/python/master/diagnosis/precheck_operator.py#L61 

Added line #L61 was not covered by tests

Check warning on line 66 in dlrover/python/master/diagnosis/precheck_operator.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

dlrover/python/master/diagnosis/precheck_operator.py#L66 

Added line #L66 was not covered by tests

Check warning on line 71 in dlrover/python/master/diagnosis/precheck_operator.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

dlrover/python/master/diagnosis/precheck_operator.py#L71 

Added line #L71 was not covered by tests

Check warning on line 73 in dlrover/python/master/main.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

dlrover/python/master/main.py#L73 

Added line #L73 was not covered by tests

Check warning on line 206 in dlrover/python/master/node/job_context.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

dlrover/python/master/node/job_context.py#L206 

Added line #L206 was not covered by tests

Check warning on line 166 in dlrover/python/master/servicer.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

dlrover/python/master/servicer.py#L166 

Added line #L166 was not covered by tests

Check warning on line 675 in dlrover/python/master/servicer.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

dlrover/python/master/servicer.py#L675 

Added line #L675 was not covered by tests

Check warning on line 39 in dlrover/python/tests/test_pre_check_operator.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

dlrover/python/tests/test_pre_check_operator.py#L39 

Added line #L39 was not covered by tests

Check warning on line 260 in dlrover/trainer/torch/elastic_run.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

dlrover/trainer/torch/elastic_run.py#L260 

Added line #L260 was not covered by tests

Check warning on line 281 in dlrover/trainer/torch/elastic_run.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

dlrover/trainer/torch/elastic_run.py#L281 

Added line #L281 was not covered by tests
View more details on Codecov