Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: cross-env and some scripts added #100

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

muskangupta-iitr
Copy link

Description

cross-env package installed successfully and corresponding changes to the scripts.

Related issues and discussion

Fixes #99

@AdrianBZG @Nikhil-Vats Please review!

@AdrianBZG
Copy link
Member

Hi @muskangupta-iitr , when I run the dev environment I'm getting this error:

`[Browsersync] Watching files...
events.js:183
throw er; // Unhandled 'error' event
^

Error: watch node_modules/minimist/test ENOSPC
at _errnoException (util.js:1022:11)
at FSWatcher.start (fs.js:1382:19)
at Object.fs.watch (fs.js:1408:11)
at createFsWatchInstance (/home/adrian.bazaga/Repos/InterMine-Data-Browser-Tool/node_modules/chokidar/lib/nodefs-handler.js:38:15)
at setFsWatchListener (/home/adrian.bazaga/Repos/InterMine-Data-Browser-Tool/node_modules/chokidar/lib/nodefs-handler.js:81:15)
at FSWatcher.NodeFsHandler._watchWithNodeFs (/home/adrian.bazaga/Repos/InterMine-Data-Browser-Tool/node_modules/chokidar/lib/nodefs-handler.js:233:14)
at FSWatcher.NodeFsHandler._handleDir (/home/adrian.bazaga/Repos/InterMine-Data-Browser-Tool/node_modules/chokidar/lib/nodefs-handler.js:429:19)
at FSWatcher. (/home/adrian.bazaga/Repos/InterMine-Data-Browser-Tool/node_modules/chokidar/lib/nodefs-handler.js:477:19)
at FSWatcher. (/home/adrian.bazaga/Repos/InterMine-Data-Browser-Tool/node_modules/chokidar/lib/nodefs-handler.js:482:16)
at FSReqWrap.oncomplete (fs.js:153:5)
`

node version: 8.10.0
npm version: 3.5.2

@muskangupta-iitr
Copy link
Author

@AdrianBZG Have you installed cross-env npm package as dev-dependency?

@AdrianBZG
Copy link
Member

I ran npm install, which should install it

@JM-Mendez
Copy link

@muskangupta-iitr see this comment on the other PR #87 (comment)

@muskangupta-iitr
Copy link
Author

@AdrianBZG I think this error is showing because every system have a limit for watching files and In your case I think it gets crossed.

echo fs.inotify.max_user_watches=582222 | sudo tee -a /etc/sysctl.conf && sudo sysctl -p

I found the solution in stack overflow for the same error. You can try above command for solving the issue.

AdrianBZG pushed a commit that referenced this pull request Sep 3, 2020
To prevent excessive network calls, this commit caches the retrieved
table rows into a `Map` of pages. It will fetch the total cache factor,
which is the amount of pages a user wishes to retrieve per request.

The cache is not currently limited to a max size, and is busted with
every new query.

The user now has 3 options for navigating the table forwards or backwards.

1. next/previous page
2. first/last page
3. direct page number input

The page navigation click events are debounced. This prevents having the user
wait on the results of fetching new results when they reach a page that
is not cached.

Closes: #99

Squashed commits:
* Display row count information
* Start a cache from the initial table row results
* Navigate forward if page exists in the cache
* Navigate backwards if page exists in the cache
* Fetch next set of rows when navigating forward and page not cached
* Reset the page number when updating the query
* Enable changing pages by inputting a number
* Display total number of pages
* Add buttons to skip to 1st and last page
* Fetch next set of rows when navigating backward and page not cached
* Bust the cache when fetching new queries
* Debounce successive page navigation click events
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[missing] cross-env module is missing for setting up environment variables
4 participants