Skip to content

[BR-1819]: fix/uploading files to workspaces#1835

Merged
xabg2 merged 1 commit intomasterfrom
fix/upload-files-in-workspaces
Feb 3, 2026
Merged

[BR-1819]: fix/uploading files to workspaces#1835
xabg2 merged 1 commit intomasterfrom
fix/upload-files-in-workspaces

Conversation

@xabg2
Copy link
Contributor

@xabg2 xabg2 commented Feb 3, 2026

Description

Use the resources token exclusively for file uploads to workspaces, and avoid using the workspace token as a resources token.

Related Issues

Related Pull Requests

Checklist

  • Changes have been tested locally.
  • Unit tests have been written or updated as necessary.
  • The code adheres to the repository's coding standards.
  • Relevant documentation has been added or updated.
  • No new warnings or errors have been introduced.
  • SonarCloud issues have been reviewed and addressed.
  • QA Passed

Testing Process

Additional Notes

@xabg2 xabg2 self-assigned this Feb 3, 2026
@xabg2 xabg2 requested review from a team, CandelR and larryrider as code owners February 3, 2026 10:53
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 3, 2026

@xabg2 xabg2 added the bug Something isn't working label Feb 3, 2026
@sg-gs
Copy link
Member

sg-gs commented Feb 3, 2026

Was this causing any issue somewhere @xabg2 ?

@xabg2
Copy link
Contributor Author

xabg2 commented Feb 3, 2026

Was this causing any issue somewhere @xabg2 ?

Yep, was causing a problem when uploading files to the workspace as I was passing the workspaceToken as resourcesToken. I added a test to ensure that if the resourcesToken is undefined, undefined is passes when creating the file entry to be sure no other value is passed.

@xabg2 xabg2 merged commit b487d6c into master Feb 3, 2026
10 checks passed
@xabg2 xabg2 deleted the fix/upload-files-in-workspaces branch February 3, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants