Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 99 additions & 1 deletion src/app/drive/services/file.service/uploadFile.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ describe('Create File Entry', () => {
const bucketId = 'bucket-123';
const fileId = 'file-id-123';
const workspaceId = 'workspace-456';
const resourcesToken = 'resources-token';
const resourcesToken = undefined;

const expectedResponse = { id: 'created-file-id', name: file.name } as unknown as DriveFileData;
const workspaceServiceSpy = vi.spyOn(workspacesService, 'createFileEntry').mockResolvedValue(expectedResponse);
Expand Down Expand Up @@ -160,6 +160,104 @@ describe('Uploading a file', () => {
vi.clearAllMocks();
});

test('When uploading a workspace file with resources token, then should be used to create a file entry', async () => {
const file: FileToUpload = {
name: 'test-file',
size: 1024,
type: 'pdf',
content: new File(['content'], 'test-file.pdf'),
parentFolderId: 'folder-uuid-123',
};
const bucketId = 'bucket-123';
const resourcesToken = 'actual-resources-token';
const workspacesToken = 'workspaces-token';
const workspaceId = 'workspace-123';

const expectedResponse = { id: 'file-id', name: file.name, uuid: 'uuid-123', thumbnails: [] };
const workspaceServiceSpy = vi
.spyOn(workspacesService, 'createFileEntry')
.mockResolvedValue(expectedResponse as unknown as DriveFileData);

const mockUploadFile = vi.fn().mockReturnValue([Promise.resolve('file-id-123'), { abort: vi.fn() }]);
mockNetwork.mockImplementation(
() =>
({
uploadFile: mockUploadFile,
}) as any,
);

await uploadFile(
'user@test',
file,
vi.fn(),
{
isTeam: false,
ownerUserAuthenticationData: {
bridgePass: 'pass',
bridgeUser: 'user',
encryptionKey: 'key',
bucketId,
token: 'token',
resourcesToken,
workspaceId,
workspacesToken,
},
},
{ taskId: 'task-1', isPaused: false, isRetriedUpload: false },
);

expect(workspaceServiceSpy).toHaveBeenCalledWith(expect.any(Object), workspaceId, resourcesToken);
});

test('When uploading a workspace file without resources token, then it should not be used to create a file entry', async () => {
const file: FileToUpload = {
name: 'test-file',
size: 1024,
type: 'pdf',
content: new File(['content'], 'test-file.pdf'),
parentFolderId: 'folder-uuid-123',
};
const bucketId = 'bucket-123';
const resourcesToken = undefined;
const workspaceId = 'workspace-123';
const workspacesToken = 'workspaces-token';

const expectedResponse = { id: 'file-id', name: file.name, uuid: 'uuid-123', thumbnails: [] };
const workspaceServiceSpy = vi
.spyOn(workspacesService, 'createFileEntry')
.mockResolvedValue(expectedResponse as unknown as DriveFileData);

const mockUploadFile = vi.fn().mockReturnValue([Promise.resolve('file-id-123'), { abort: vi.fn() }]);
mockNetwork.mockImplementation(
() =>
({
uploadFile: mockUploadFile,
}) as any,
);

await uploadFile(
'user@test',
file,
vi.fn(),
{
isTeam: false,
ownerUserAuthenticationData: {
bridgePass: 'pass',
bridgeUser: 'user',
encryptionKey: 'key',
bucketId,
token: 'token',
resourcesToken,
workspaceId,
workspacesToken,
},
},
{ taskId: 'task-1', isPaused: false, isRetriedUpload: false },
);

expect(workspaceServiceSpy).toHaveBeenCalledWith(expect.any(Object), workspaceId, resourcesToken);
});

test('When uploading a file with size 0 and no workspace, then it should create file entry directly without uploading', async () => {
const file: FileToUpload = {
name: 'empty-file',
Expand Down
6 changes: 3 additions & 3 deletions src/app/drive/services/file.service/uploadFile.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ import { getEnvironmentConfig } from '../network.service';
import { generateThumbnailFromFile } from '../thumbnail.service';
import { OwnerUserAuthenticationData } from 'app/network/types';
import { FileToUpload } from './types';
import { FileEntry } from '@internxt/sdk/dist/workspaces';
import { DriveFileData } from '@internxt/sdk/dist/drive/storage/types';
import { BucketNotFoundError, FileIdRequiredError } from './upload.errors';
import { isFileEmpty } from 'utils/isFileEmpty';
import { FileEntry } from '@internxt/sdk/dist/workspaces';

export interface FileUploadOptions {
isTeam: boolean;
Expand Down Expand Up @@ -104,7 +104,7 @@ export async function uploadFile(
return createFileEntry({
bucketId: bucketId,
file,
resourcesToken: resourcesToken ?? workspacesToken,
resourcesToken: resourcesToken,
workspaceId: workspaceId,
ownerToken: workspacesToken,
});
Expand Down Expand Up @@ -141,7 +141,7 @@ export async function uploadFile(
fileId: fileId,
file,
isWorkspaceUpload: !!isWorkspacesUpload,
resourcesToken: resourcesToken ?? workspacesToken,
resourcesToken: resourcesToken,
workspaceId: workspaceId,
ownerToken: workspacesToken,
});
Expand Down
2 changes: 1 addition & 1 deletion src/app/network/types/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,5 +43,5 @@ export interface OwnerUserAuthenticationData {
// to manage B2B workspaces
workspaceId?: string;
workspacesToken?: string;
resourcesToken: string;
resourcesToken?: string;
}
Loading