[_] fix(thumbnails): use workspace bucket for workspace uploads #1838
+208
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglas-xt
requested review from
a team,
CandelR and
larryrider
as code owners
douglas-xt
changed the title
Deploying drive-web with
|
| Latest commit: |
9a1962a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f896954f.drive-web.pages.dev |
| Branch Preview URL: | https://fix-thumbnail-workspace-cred.drive-web.pages.dev |
sg-gs
reviewed
Feb 5, 2026
| }, | ||
| { | ||
| isTeam: false, | ||
| isTeam: !!this.options?.ownerUserAuthenticationData?.workspaceId, |
Member
There was a problem hiding this comment.
Is this flag the workspace correct flag or a deprecated flag of the previous deprecated version? Provide a GitHub ref demonstrating so pls
Contributor
Author
…kward compatibility for downloads
CandelR
approved these changes
Feb 5, 2026
CandelR
approved these changes
Feb 5, 2026
Collaborator
CandelR
left a comment
CandelR
left a comment
There was a problem hiding this comment.
@douglas-xt Remember to fill the testing process :). Good job 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When users upload files from desktop clients to their workspaces, both the file and thumbnail are sent to the correct workspace bucket using the appropriate context. However, the web application always uses the personal storage context when downloading thumbnails, regardless of where they were actually stored. This causes thumbnails from workspace uploads to fail to display. The issue only appears with desktop uploads because when uploading directly from web, it uses the same incorrect personal context for both upload and download, so they accidentally match and work.
The file upload flow was corrected by adjusting how we determine whether a file belongs to a workspace or personal storage. Instead of using a hardcoded value, the upload context is now evaluated dynamically to retrieve the appropriate credentials from the environment. This ensures that when uploading a file to a workspace, both the file and its thumbnail are stored in the same workspace storage location, guaranteeing that files and their thumbnails always reside together in the correct storage space.
Additionally, backward compatibility was implemented for existing thumbnails that were previously stored in the wrong location. When downloading a thumbnail, the actual storage location is verified and the appropriate credentials are used to retrieve it. This means users with older thumbnails that were incorrectly stored in personal buckets can still view them seamlessly, while all new uploads follow the corrected behavior. This approach ensures a smooth transition without requiring migration of existing thumbnails or disrupting the user experience.
Related Issues
Related Pull Requests
Checklist
Testing Process
Additional Notes