Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dss] Op. Intent handler: make mentioning OIR being updated optional in key parameter #1006

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

Shastick
Copy link
Contributor

@Shastick Shastick commented Mar 11, 2024

The description for the key parameter states:

Proof that the USS creating or mutating this operational intent was
aware of the current state of the airspace, with the expectation
that this operational intent is therefore deconflicted from all
relevant features in the airspace. This field is not required when
declaring an operational intent Nonconforming or Contingent, or when
there are no relevant Entities in the airspace, but is otherwise
required. OVNs for constraints are required if and only if the USS
managing this operational intent is performing the constraint
processing role, which is indicated by whether the subscription
associated with this operational intent triggers notifications for
constraints.
The key does not need to contain the OVN for the
operational intent being updated.

However the current implementation will return a 409 if the OVN of the operational intent reference is not present in the key.

This contradicts the specification, and the present PR is a suggested fix.

Note that this will require this prober PR to be merged and released for the CI to pass.

@Shastick Shastick marked this pull request as draft March 11, 2024 10:47
@Shastick Shastick changed the title [dss] operational_intents_handler: make mentioning OIR being updated optional in key parameter [dss] Op. Intent handler: make mentioning OIR being updated optional in key parameter Mar 11, 2024
@Shastick Shastick marked this pull request as ready for review March 11, 2024 20:17
@Shastick Shastick force-pushed the optional-self-ref-key branch from 5e2a653 to 7c48fbe Compare March 14, 2024 08:10
@barroco barroco merged commit 6ab32f9 into interuss:master Mar 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants