[prober] update prober to support next DSS version #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shastick
force-pushed
the
update-prober-for-dss-key-fix
branch
from
1923ddf to
6fb6aa9
Compare
Shastick
force-pushed
the
update-prober-for-dss-key-fix
branch
from
6fb6aa9 to
2e7af6e
Compare
barroco
approved these changes
Mar 12, 2024
github-actions bot
added a commit
that referenced
this pull request
Mar 12, 2024
[prober] update prober to support the new DSS version 0d73a7b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're updating the DSS: the change is about the validation of the
keyfield of requests for updating an operational intent reference.Currently, when an OIR is updated, the DSS will expect the OVN of that OIR to be passed in the
keyfield. This contradicts the specification, so required a DSS update.This PR updates the prober (which was correctly testing the previous behavior) for it to accept the new behavior.
This should be compatible with the current and upcoming version of the DSS (it was tested against the new one already)