[uss_qualifier/scenarios/netrid] specify some check severity in test scenario documentation only (contrib #404)

[the-glu]

This PR move some check's severity definition into documentation, contributing to #404.

There are separate commits for easier review. I had issue with spacing and emojis, this is fixed in the last commit.

With shared tests, some checks are not 100% converted (e.g. heavy_traffic_concurent's cleanup).

The removal of severity from code created issues with undocumented checks (at least Recent positions timestamps and Recent positions for aircraft crossing the requested area boundary show only one position before or after crossing).
It does seems that those can be run without documentation, (when called from _assert_evaluate_sp_flight_recent_positions?), and no severity is set when building undocumented check. fd87973 add a default severity as a workaround, but this is something that should probably be discussed.

As an estimation for work left to be done, this reduced usage to severity in scenarios from ~200 to ~170.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: the-glu / name: Maximilien Cuony (4553898, 9a84926, 9ce3338, 93af520, 891455c, fd87973, b033be9, c242282)

[BenjaminPelletier]

This looks great. My "nit" comments are primarily placeholders to see whether we should re-evaluate the severity of those check failures (I'm sure you've copied the current values correctly). Please feel free to resolve as you think is appropriate (either accept or reject my suggestions) -- the difference between Medium severity and High severity is whether the test can continue. If later steps depend on the thing we're checking succeeding, then a check failure should be High severity because we can no longer depend on expected behavior when we get to those later steps. Otherwise, Medium severity is preferred.

@mickmis or @barroco FYI this looks good to merge to me after @the-glu addresses the comments

[the-glu]

This looks great. My "nit" comments are primarily placeholders to see whether we should re-evaluate the severity of those check failures (I'm sure you've copied the current values correctly).

Yes, I applied the comments accordingly (in both v22a/v19 in all cases). Some of severity values are coming from the default High severity in handle_query_result and indeed should be lowered :)

[Shastick]

Looks good, with some typos

[BenjaminPelletier]

Ready to merge after Shastick's typos IMO