-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: paginate API calls #1332
Merged
Merged
perf: paginate API calls #1332
Changes from 112 commits
Commits
Show all changes
129 commits
Select commit
Hold shift + click to select a range
89f9012
Switch to limit offset pagination in the backend
nas-tabchiche 3c030c1
Cast PAGIKNATE_BY to int
nas-tabchiche 606d7a9
Backend pagination PoC
nas-tabchiche d1fb264
Merge branch 'main' into CA-582-handle-backend-pagination
nas-tabchiche 9af35cf
Fix RequirementAssessmentViewSet search fields
nas-tabchiche b0775bd
Handle search
nas-tabchiche 9824759
handle rowsPerPage
nas-tabchiche 6782d19
Invalidate handler onMount
nas-tabchiche ac296de
Invalidate handler on seach
nas-tabchiche 93f8671
Return response instead of response.results
nas-tabchiche cfbcfda
Fix composer regression
nas-tabchiche 2f2de8c
Some tidying
nas-tabchiche 19e2a66
Allow ordering against all model fields by default
nas-tabchiche 5900564
Fix Th sort styling
nas-tabchiche d41b317
Merge branch 'main' into CA-582-handle-backend-pagination
nas-tabchiche 1358a24
chore: some tidying
nas-tabchiche 09f720b
Merge branch 'main' into CA-582-handle-backend-pagination
nas-tabchiche f1a4c3d
chore: some tidying
nas-tabchiche 07eab67
Dynamically import either server or client ModelTable component
nas-tabchiche db7e502
refactor: loaded libraries table
nas-tabchiche e148c88
Forward slots to client/server ModelTable
nas-tabchiche 4681a18
Remove dead code
nas-tabchiche 9049fc1
Refactor load functions
nas-tabchiche e26a0ff
Improve libraries routing
nas-tabchiche 337d3a9
Improve slot forwarding on ModelTable
nas-tabchiche d738d1d
Add null checks
nas-tabchiche 2d7b08f
Use new loaded-libraries routes
nas-tabchiche bf24bc6
Remove dead code
nas-tabchiche c5ce0db
Merge branch 'main' into CA-582-handle-backend-pagination
nas-tabchiche b84f57a
Merge branch 'main' into CA-582-handle-backend-pagination
nas-tabchiche cdceea5
Get rid of the dynamic import
nas-tabchiche 3f9d9ea
Use URLSearchParams structure
nas-tabchiche df7e8f3
Fix potential memory leak in riskMatricesPreview function
nas-tabchiche 7d94926
Remove import logic from loaded libraries route
nas-tabchiche 8144aba
Optimize database query and simplify version comparison logic
nas-tabchiche 3f4f6f8
Change HTTP method from GET to POST for library import
nas-tabchiche 5fbac67
Tidy ModelTable component
nas-tabchiche f01ad2f
Add some error handling around fetch requests
nas-tabchiche d0b5c9e
Improve accessibility on ModelTable components
nas-tabchiche 090aecc
Fix server-side RowsPerPage component
nas-tabchiche 52b1fbc
Merge branch 'main' into CA-582-handle-backend-pagination
nas-tabchiche 045202d
Add null checks for library objects
nas-tabchiche 27f0c6c
Add /loaded-libraries/available-updates endpoint
nas-tabchiche 96ac4ee
Remove dead code
nas-tabchiche fccd861
Use new endpoint to get updatable libraries
nas-tabchiche 2aa7854
Adapt new AutocompleteSelect to page serialization
nas-tabchiche 07343d8
Update API tests to use POST for library imports
nas-tabchiche 2869d7d
Fix language display on stored and loaded libraries model tables
nas-tabchiche 928e075
Merge branch 'main' into CA-582-handle-backend-pagination
nas-tabchiche a43f11d
Properly get row metadata
nas-tabchiche 8e2e92b
Merge branch 'main' into CA-582-handle-backend-pagination
nas-tabchiche 67553b0
Return whole response in third party urlmodels endpoint
nas-tabchiche 2112461
Remove dead code
nas-tabchiche 6529613
Fetch domain filter choices from API
nas-tabchiche a02032c
Add null check to initialData
nas-tabchiche 851ebc0
Handle array filter values
nas-tabchiche 65c8dd9
Fetch model filter choices from API
nas-tabchiche 0e04b2f
Handle server-side filters
nas-tabchiche 860142d
Delete client-side ModelTable component
nas-tabchiche cfb352d
Merge branch 'main' into CA-582-handle-backend-pagination
nas-tabchiche b91f240
Fix filters close query
nas-tabchiche 78f504e
Manage multiple value filters
nas-tabchiche f886a1a
Merge branch 'main' into CA-582-handle-backend-pagination
eric-intuitem 5b6fc03
Allow multiple options for perimeter folders
nas-tabchiche 7f07929
Merge branch 'main' into CA-582-handle-backend-pagination
nas-tabchiche a41b04a
Forward static filter choices to frontend
nas-tabchiche 6806cb4
Write FilterKeys type
nas-tabchiche cb18f93
Merge branch 'main' into CA-582-handle-backend-pagination
nas-tabchiche 68da4c3
Static options fetch PoC
nas-tabchiche 850e2dc
Merge branch 'main' into CA-582-handle-backend-pagination
nas-tabchiche 5756b3b
Remove url parameters from filter endpoints
nas-tabchiche 4ec1de2
Fix incomplete filter visibility logic
nas-tabchiche 81cc975
Add filter fieldContext on AutocompleteSelect
nas-tabchiche 21e5bf4
Always display all filters
nas-tabchiche a3daacf
Add data-testid for RowCount
nas-tabchiche 1bf7032
Fix table handler fetch endpoints
nas-tabchiche eb84c43
Always display all filters
nas-tabchiche a21d6a3
Add risk acceptance state choices endpoint
nas-tabchiche db8efef
Support some more filters
nas-tabchiche 8358b17
Merge branch 'main' into CA-582-handle-backend-pagination
nas-tabchiche f7cb3e7
Internationalize singular stakeholder
nas-tabchiche 354cf5d
Remove trailing slash for ebios-rm models' endpointUrl
nas-tabchiche a80878f
Some tidying
nas-tabchiche 59f6c14
Accept both hyphen and underscores for filter keys
nas-tabchiche 77db33f
Try to use model.endpointUrl before urlmodel
nas-tabchiche 4a8da24
Add custom endpoint for ebios-rm studies
nas-tabchiche f1af2cc
Add filterset fields to ebios-rm viewsets
nas-tabchiche 7704b98
Add and fix existing filters
nas-tabchiche f446068
Add finer-grained table handler invalidation to avoid double fetching
nas-tabchiche 8d302bc
refactor: make StoredLibrary content a JSON field
nas-tabchiche c2e24c7
Merge branch 'refactor/make-storedlibrary-content-json' into CA-582-h…
nas-tabchiche af6ca51
chore: ruff format
nas-tabchiche e1f3f9d
Merge branch 'refactor/make-storedlibrary-content-json' into CA-582-h…
nas-tabchiche 02d2827
Adapt stored libraries object type filter to server-side filtering
nas-tabchiche b2a5665
Clean up table.ts file
nas-tabchiche d541659
Rename extraProps to props
nas-tabchiche ff9ff62
Adapt loaded libraries object type filter to server-side filtering
nas-tabchiche 491dfdb
Adapt loaded libraries update available filter to server-side filtering
nas-tabchiche 13d9290
Merge branch 'main' into CA-582-handle-backend-pagination
nas-tabchiche 4e75d50
Merge branch 'main' into CA-582-handle-backend-pagination
ab-smith d5000a9
Merge branch 'CA-582-handle-backend-pagination' of github.com:intuite…
nas-tabchiche ed32c14
fix: store risk matrix json definition as a dict, not a str
nas-tabchiche 706b420
Merge branch 'fix/store-matrix-json-definition-as-dict-not-str' into …
nas-tabchiche 916623d
Adapt risk matrix filters to server-side pagination
nas-tabchiche 1e43048
chore: migs
nas-tabchiche 9f73a39
Reove debug log
nas-tabchiche 5052465
Properly initialize data handler if source is provided
nas-tabchiche 6e6fef3
Merge branch 'main' into CA-582-handle-backend-pagination
eric-intuitem 7bd2a34
fix migrations
eric-intuitem 450743f
Update 0055_alter_storedlibrary_content.py
eric-intuitem 59a4cb2
Merge branch 'main' into CA-582-handle-backend-pagination
eric-intuitem ee3332a
Merge branch 'main' into CA-582-handle-backend-pagination
eric-intuitem ec91639
try fix functional tests
eric-intuitem e7b97e0
Merge branch 'main' into CA-582-handle-backend-pagination
nas-tabchiche 4c5eef1
fix: add safeguard to matrix data migration in case json_definition i…
nas-tabchiche a3dac9d
Merge branch 'refactor/add-safeguards-to-matrix-migration' into CA-58…
nas-tabchiche 688ea92
Properly display loaded library delete button
nas-tabchiche 509d8b9
Pre-populate filter values from url search params
nas-tabchiche f8689d5
Unwrap library content storage from json.loads
nas-tabchiche 4b9eb0c
Close lingering modals in user route tests
nas-tabchiche 01b272e
Remove framework url filter
nas-tabchiche 10c299d
Move 3s timeout to getByTestId
nas-tabchiche 00db82b
Remove outdated core.filters module
nas-tabchiche ea9882c
Revert "Remove framework url filter"
nas-tabchiche 3c926c0
Add ref_id search field to library view sets
nas-tabchiche 7290089
Add ref_id column to library model tables
nas-tabchiche 06a4af8
Revert "Move 3s timeout to getByTestId"
nas-tabchiche 2cf7729
Unwrap library content storage from json.loads
nas-tabchiche eccea8f
Store storedlibrary content as dict not str
nas-tabchiche File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Add error handling to risk_scoring function.
The function should handle potential errors when accessing the grid:
📝 Committable suggestion