chore: rename type_ fields
#318
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -56,6 +56,7 @@ pub struct EventFilter { | |||
| pub struct Event { | |||
| pub sending_module: Option<MoveModuleQuery>, | |||
| pub sender: Option<GQLAddress>, | |||
| // TODO thibault | |||
| pub type_: MoveType, | |||
Member
Author
There was a problem hiding this comment.
Did this one not need a #[cynic(rename = "type")]?
Contributor
There was a problem hiding this comment.
I actually verified, that trailing underscores do not prevent the match against the schema. You can add as many as you want and it still works. Mapping fails however at compile-time if you prepend it or change the field name in any other way. Not sure this is documented well. We probably should still cynic-rename it just in case that doesn't work anymore at some point.
| @@ -134,7 +134,7 @@ pub struct MoveEnumVariant { | |||
| pub struct MoveField { | |||
| pub name: String, | |||
| #[cynic(rename = "type")] | |||
| pub type_: Option<OpenMoveType>, | |||
| pub type_tag: Option<OpenMoveType>, | |||
Member
Author
There was a problem hiding this comment.
Suggested change
| pub type_tag: Option<OpenMoveType>, | |
| pub open_move_type: Option<OpenMoveType>, |
?
Contributor
There was a problem hiding this comment.
move_type is probably also fine. Looking at the other fields they are named very chill as well, so not sure it's necessary to be super correct here.
Alex6323
approved these changes
Oct 29, 2025
| pub struct Event { | ||
| pub sending_module: Option<MoveModuleQuery>, | ||
| pub sender: Option<GQLAddress>, | ||
| // TODO thibault |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.