Skip to content

chore: rename type_ fields #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: develop
Choose a base branch
from
Draft

chore: rename type_ fields #318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
509ca3e
chore: rename `type_` fields
thibault-martinez Oct 15, 2025
6a9b1d0
update bindings
thibault-martinez Oct 15, 2025
026a63f
nit
thibault-martinez Oct 15, 2025
089705a
Merge branch 'sdk-bindings' into chore/rename-type_
thibault-martinez Oct 27, 2025
8a2a52b
Merge branch 'sdk-bindings' into chore/rename-type_
thibault-martinez Oct 29, 2025
4881093
type_filter
thibault-martinez Oct 29, 2025
54bd772
struct_tag
thibault-martinez Oct 29, 2025
4a03d5a
clippy
thibault-martinez Oct 29, 2025
253139b
Merge branch 'develop' into chore/rename-type_
thibault-martinez Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions bindings/go/iota_sdk_ffi/iota_sdk_ffi.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30130,7 +30130,7 @@ type Event struct {
// emitted.
Sender *Address
// The type of the event emitted
Type string
TypeTag string
// BCS serialized bytes of the event
Contents []byte
// UTC timestamp in milliseconds since epoch (1/1/1970)
Expand All @@ -30145,7 +30145,7 @@ func (r *Event) Destroy() {
FfiDestroyerObjectId{}.Destroy(r.PackageId);
FfiDestroyerString{}.Destroy(r.Module);
FfiDestroyerAddress{}.Destroy(r.Sender);
FfiDestroyerString{}.Destroy(r.Type);
FfiDestroyerString{}.Destroy(r.TypeTag);
FfiDestroyerBytes{}.Destroy(r.Contents);
FfiDestroyerString{}.Destroy(r.Timestamp);
FfiDestroyerString{}.Destroy(r.Data);
Expand Down Expand Up @@ -30181,7 +30181,7 @@ func (c FfiConverterEvent) Write(writer io.Writer, value Event) {
FfiConverterObjectIdINSTANCE.Write(writer, value.PackageId);
FfiConverterStringINSTANCE.Write(writer, value.Module);
FfiConverterAddressINSTANCE.Write(writer, value.Sender);
FfiConverterStringINSTANCE.Write(writer, value.Type);
FfiConverterStringINSTANCE.Write(writer, value.TypeTag);
FfiConverterBytesINSTANCE.Write(writer, value.Contents);
FfiConverterStringINSTANCE.Write(writer, value.Timestamp);
FfiConverterStringINSTANCE.Write(writer, value.Data);
Expand Down Expand Up @@ -30754,12 +30754,12 @@ func (_ FfiDestroyerMoveEnumVariant) Destroy(value MoveEnumVariant) {
}
type MoveField struct {
Name string
Type *OpenMoveType
TypeTag *OpenMoveType
}

func (r *MoveField) Destroy() {
FfiDestroyerString{}.Destroy(r.Name);
FfiDestroyerOptionalOpenMoveType{}.Destroy(r.Type);
FfiDestroyerOptionalOpenMoveType{}.Destroy(r.TypeTag);
}

type FfiConverterMoveField struct {}
Expand All @@ -30783,7 +30783,7 @@ func (c FfiConverterMoveField) Lower(value MoveField) C.RustBuffer {

func (c FfiConverterMoveField) Write(writer io.Writer, value MoveField) {
FfiConverterStringINSTANCE.Write(writer, value.Name);
FfiConverterOptionalOpenMoveTypeINSTANCE.Write(writer, value.Type);
FfiConverterOptionalOpenMoveTypeINSTANCE.Write(writer, value.TypeTag);
}

type FfiDestroyerMoveField struct {}
Expand Down Expand Up @@ -31412,13 +31412,13 @@ func (_ FfiDestroyerNameRegistrationPage) Destroy(value NameRegistrationPage) {
value.Destroy()
}
type ObjectFilter struct {
TypeTag *string
TypeFilter *string
Owner **Address
ObjectIds *[]*ObjectId
}

func (r *ObjectFilter) Destroy() {
FfiDestroyerOptionalString{}.Destroy(r.TypeTag);
FfiDestroyerOptionalString{}.Destroy(r.TypeFilter);
FfiDestroyerOptionalAddress{}.Destroy(r.Owner);
FfiDestroyerOptionalSequenceObjectId{}.Destroy(r.ObjectIds);
}
Expand All @@ -31444,7 +31444,7 @@ func (c FfiConverterObjectFilter) Lower(value ObjectFilter) C.RustBuffer {
}

func (c FfiConverterObjectFilter) Write(writer io.Writer, value ObjectFilter) {
FfiConverterOptionalStringINSTANCE.Write(writer, value.TypeTag);
FfiConverterOptionalStringINSTANCE.Write(writer, value.TypeFilter);
FfiConverterOptionalAddressINSTANCE.Write(writer, value.Owner);
FfiConverterOptionalSequenceObjectIdINSTANCE.Write(writer, value.ObjectIds);
}
Expand Down
22 changes: 11 additions & 11 deletions bindings/kotlin/lib/iota_sdk/iota_sdk_ffi.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51364,7 +51364,7 @@ data class Event (
/**
* The type of the event emitted
*/
var `type`: kotlin.String,
var `typeTag`: kotlin.String,
/**
* BCS serialized bytes of the event
*/
Expand All @@ -51390,7 +51390,7 @@ data class Event (
this.`packageId`,
this.`module`,
this.`sender`,
this.`type`,
this.`typeTag`,
this.`contents`,
this.`timestamp`,
this.`data`,
Expand Down Expand Up @@ -51422,7 +51422,7 @@ public object FfiConverterTypeEvent: FfiConverterRustBuffer<Event> {
FfiConverterTypeObjectId.allocationSize(value.`packageId`) +
FfiConverterString.allocationSize(value.`module`) +
FfiConverterTypeAddress.allocationSize(value.`sender`) +
FfiConverterString.allocationSize(value.`type`) +
FfiConverterString.allocationSize(value.`typeTag`) +
FfiConverterByteArray.allocationSize(value.`contents`) +
FfiConverterString.allocationSize(value.`timestamp`) +
FfiConverterString.allocationSize(value.`data`) +
Expand All @@ -51433,7 +51433,7 @@ public object FfiConverterTypeEvent: FfiConverterRustBuffer<Event> {
FfiConverterTypeObjectId.write(value.`packageId`, buf)
FfiConverterString.write(value.`module`, buf)
FfiConverterTypeAddress.write(value.`sender`, buf)
FfiConverterString.write(value.`type`, buf)
FfiConverterString.write(value.`typeTag`, buf)
FfiConverterByteArray.write(value.`contents`, buf)
FfiConverterString.write(value.`timestamp`, buf)
FfiConverterString.write(value.`data`, buf)
Expand Down Expand Up @@ -52016,7 +52016,7 @@ public object FfiConverterTypeMoveEnumVariant: FfiConverterRustBuffer<MoveEnumVa

data class MoveField (
var `name`: kotlin.String,
var `type`: OpenMoveType? = null
var `typeTag`: OpenMoveType? = null
) {

companion object
Expand All @@ -52035,12 +52035,12 @@ public object FfiConverterTypeMoveField: FfiConverterRustBuffer<MoveField> {

override fun allocationSize(value: MoveField) = (
FfiConverterString.allocationSize(value.`name`) +
FfiConverterOptionalTypeOpenMoveType.allocationSize(value.`type`)
FfiConverterOptionalTypeOpenMoveType.allocationSize(value.`typeTag`)
)

override fun write(value: MoveField, buf: ByteBuffer) {
FfiConverterString.write(value.`name`, buf)
FfiConverterOptionalTypeOpenMoveType.write(value.`type`, buf)
FfiConverterOptionalTypeOpenMoveType.write(value.`typeTag`, buf)
}
}

Expand Down Expand Up @@ -52689,7 +52689,7 @@ public object FfiConverterTypeNameRegistrationPage: FfiConverterRustBuffer<NameR


data class ObjectFilter (
var `typeTag`: kotlin.String? = null,
var `typeFilter`: kotlin.String? = null,
var `owner`: Address? = null,
var `objectIds`: List<ObjectId>? = null
) : Disposable {
Expand All @@ -52698,7 +52698,7 @@ data class ObjectFilter (
override fun destroy() {

Disposable.destroy(
this.`typeTag`,
this.`typeFilter`,
this.`owner`,
this.`objectIds`
)
Expand All @@ -52720,13 +52720,13 @@ public object FfiConverterTypeObjectFilter: FfiConverterRustBuffer<ObjectFilter>
}

override fun allocationSize(value: ObjectFilter) = (
FfiConverterOptionalString.allocationSize(value.`typeTag`) +
FfiConverterOptionalString.allocationSize(value.`typeFilter`) +
FfiConverterOptionalTypeAddress.allocationSize(value.`owner`) +
FfiConverterOptionalSequenceTypeObjectId.allocationSize(value.`objectIds`)
)

override fun write(value: ObjectFilter, buf: ByteBuffer) {
FfiConverterOptionalString.write(value.`typeTag`, buf)
FfiConverterOptionalString.write(value.`typeFilter`, buf)
FfiConverterOptionalTypeAddress.write(value.`owner`, buf)
FfiConverterOptionalSequenceTypeObjectId.write(value.`objectIds`, buf)
}
Expand Down
56 changes: 28 additions & 28 deletions bindings/python/lib/iota_sdk_ffi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14364,7 +14364,7 @@ class Event:
emitted.
"""

type: "str"
type_tag: "str"
"""
The type of the event emitted
"""
Expand All @@ -14389,18 +14389,18 @@ class Event:
Representation of a Move value in JSON
"""

def __init__(self, *, package_id: "ObjectId", module: "str", sender: "Address", type: "str", contents: "bytes", timestamp: "str", data: "str", json: "str"):
def __init__(self, *, package_id: "ObjectId", module: "str", sender: "Address", type_tag: "str", contents: "bytes", timestamp: "str", data: "str", json: "str"):
self.package_id = package_id
self.module = module
self.sender = sender
self.type = type
self.type_tag = type_tag
self.contents = contents
self.timestamp = timestamp
self.data = data
self.json = json

def __str__(self):
return "Event(package_id={}, module={}, sender={}, type={}, contents={}, timestamp={}, data={}, json={})".format(self.package_id, self.module, self.sender, self.type, self.contents, self.timestamp, self.data, self.json)
return "Event(package_id={}, module={}, sender={}, type_tag={}, contents={}, timestamp={}, data={}, json={})".format(self.package_id, self.module, self.sender, self.type_tag, self.contents, self.timestamp, self.data, self.json)

def __eq__(self, other):
if self.package_id != other.package_id:
Expand All @@ -14409,7 +14409,7 @@ def __eq__(self, other):
return False
if self.sender != other.sender:
return False
if self.type != other.type:
if self.type_tag != other.type_tag:
return False
if self.contents != other.contents:
return False
Expand All @@ -14428,7 +14428,7 @@ def read(buf):
package_id=_UniffiConverterTypeObjectId.read(buf),
module=_UniffiConverterString.read(buf),
sender=_UniffiConverterTypeAddress.read(buf),
type=_UniffiConverterString.read(buf),
type_tag=_UniffiConverterString.read(buf),
contents=_UniffiConverterBytes.read(buf),
timestamp=_UniffiConverterString.read(buf),
data=_UniffiConverterString.read(buf),
Expand All @@ -14440,7 +14440,7 @@ def check_lower(value):
_UniffiConverterTypeObjectId.check_lower(value.package_id)
_UniffiConverterString.check_lower(value.module)
_UniffiConverterTypeAddress.check_lower(value.sender)
_UniffiConverterString.check_lower(value.type)
_UniffiConverterString.check_lower(value.type_tag)
_UniffiConverterBytes.check_lower(value.contents)
_UniffiConverterString.check_lower(value.timestamp)
_UniffiConverterString.check_lower(value.data)
Expand All @@ -14451,7 +14451,7 @@ def write(value, buf):
_UniffiConverterTypeObjectId.write(value.package_id, buf)
_UniffiConverterString.write(value.module, buf)
_UniffiConverterTypeAddress.write(value.sender, buf)
_UniffiConverterString.write(value.type, buf)
_UniffiConverterString.write(value.type_tag, buf)
_UniffiConverterBytes.write(value.contents, buf)
_UniffiConverterString.write(value.timestamp, buf)
_UniffiConverterString.write(value.data, buf)
Expand Down Expand Up @@ -15100,21 +15100,21 @@ def write(value, buf):

class MoveField:
name: "str"
type: "typing.Optional[OpenMoveType]"
def __init__(self, *, name: "str", type: "typing.Optional[OpenMoveType]" = _DEFAULT):
type_tag: "typing.Optional[OpenMoveType]"
def __init__(self, *, name: "str", type_tag: "typing.Optional[OpenMoveType]" = _DEFAULT):
self.name = name
if type is _DEFAULT:
self.type = None
if type_tag is _DEFAULT:
self.type_tag = None
else:
self.type = type
self.type_tag = type_tag

def __str__(self):
return "MoveField(name={}, type={})".format(self.name, self.type)
return "MoveField(name={}, type_tag={})".format(self.name, self.type_tag)

def __eq__(self, other):
if self.name != other.name:
return False
if self.type != other.type:
if self.type_tag != other.type_tag:
return False
return True

Expand All @@ -15123,18 +15123,18 @@ class _UniffiConverterTypeMoveField(_UniffiConverterRustBuffer):
def read(buf):
return MoveField(
name=_UniffiConverterString.read(buf),
type=_UniffiConverterOptionalTypeOpenMoveType.read(buf),
type_tag=_UniffiConverterOptionalTypeOpenMoveType.read(buf),
)

@staticmethod
def check_lower(value):
_UniffiConverterString.check_lower(value.name)
_UniffiConverterOptionalTypeOpenMoveType.check_lower(value.type)
_UniffiConverterOptionalTypeOpenMoveType.check_lower(value.type_tag)

@staticmethod
def write(value, buf):
_UniffiConverterString.write(value.name, buf)
_UniffiConverterOptionalTypeOpenMoveType.write(value.type, buf)
_UniffiConverterOptionalTypeOpenMoveType.write(value.type_tag, buf)


class MoveFunctionConnection:
Expand Down Expand Up @@ -15812,14 +15812,14 @@ def write(value, buf):


class ObjectFilter:
type_tag: "typing.Optional[str]"
type_filter: "typing.Optional[str]"
owner: "typing.Optional[Address]"
object_ids: "typing.Optional[typing.List[ObjectId]]"
def __init__(self, *, type_tag: "typing.Optional[str]" = _DEFAULT, owner: "typing.Optional[Address]" = _DEFAULT, object_ids: "typing.Optional[typing.List[ObjectId]]" = _DEFAULT):
if type_tag is _DEFAULT:
self.type_tag = None
def __init__(self, *, type_filter: "typing.Optional[str]" = _DEFAULT, owner: "typing.Optional[Address]" = _DEFAULT, object_ids: "typing.Optional[typing.List[ObjectId]]" = _DEFAULT):
if type_filter is _DEFAULT:
self.type_filter = None
else:
self.type_tag = type_tag
self.type_filter = type_filter
if owner is _DEFAULT:
self.owner = None
else:
Expand All @@ -15830,10 +15830,10 @@ def __init__(self, *, type_tag: "typing.Optional[str]" = _DEFAULT, owner: "typin
self.object_ids = object_ids

def __str__(self):
return "ObjectFilter(type_tag={}, owner={}, object_ids={})".format(self.type_tag, self.owner, self.object_ids)
return "ObjectFilter(type_filter={}, owner={}, object_ids={})".format(self.type_filter, self.owner, self.object_ids)

def __eq__(self, other):
if self.type_tag != other.type_tag:
if self.type_filter != other.type_filter:
return False
if self.owner != other.owner:
return False
Expand All @@ -15845,20 +15845,20 @@ class _UniffiConverterTypeObjectFilter(_UniffiConverterRustBuffer):
@staticmethod
def read(buf):
return ObjectFilter(
type_tag=_UniffiConverterOptionalString.read(buf),
type_filter=_UniffiConverterOptionalString.read(buf),
owner=_UniffiConverterOptionalTypeAddress.read(buf),
object_ids=_UniffiConverterOptionalSequenceTypeObjectId.read(buf),
)

@staticmethod
def check_lower(value):
_UniffiConverterOptionalString.check_lower(value.type_tag)
_UniffiConverterOptionalString.check_lower(value.type_filter)
_UniffiConverterOptionalTypeAddress.check_lower(value.owner)
_UniffiConverterOptionalSequenceTypeObjectId.check_lower(value.object_ids)

@staticmethod
def write(value, buf):
_UniffiConverterOptionalString.write(value.type_tag, buf)
_UniffiConverterOptionalString.write(value.type_filter, buf)
_UniffiConverterOptionalTypeAddress.write(value.owner, buf)
_UniffiConverterOptionalSequenceTypeObjectId.write(value.object_ids, buf)

Expand Down
2 changes: 1 addition & 1 deletion crates/iota-sdk-ffi/src/transaction_builder/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ impl TransactionBuilder {
use iota_sdk::transaction_builder::unresolved::{Command, MakeMoveVector};
self.write(|builder| {
let cmd = Command::MakeMoveVector(MakeMoveVector {
type_: Some(type_tag.0.clone()),
type_tag: Some(type_tag.0.clone()),
elements: elements
.iter()
.map(|e| builder.apply_argument(e.as_ref()))
Expand Down
10 changes: 5 additions & 5 deletions crates/iota-sdk-ffi/src/types/events.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ pub struct Event {
/// emitted.
pub sender: Arc<Address>,
/// The type of the event emitted
pub type_: String,
pub type_tag: String,
/// BCS serialized bytes of the event
pub contents: Vec<u8>,
/// UTC timestamp in milliseconds since epoch (1/1/1970)
Expand All @@ -57,7 +57,7 @@ impl From<iota_sdk::graphql_client::query_types::Event> for Event {
))),
module: sending_module.name.clone(),
sender: Arc::new(Address(value.sender.as_ref().unwrap().address)),
type_: value.type_.repr.clone(),
type_tag: value.type_.repr.clone(),
contents: base64ct::Base64::decode_vec(&value.bcs.0).unwrap_or_default(),
timestamp: value.timestamp.as_ref().unwrap().0.clone(),
data: value.data.0.to_string(),
Expand All @@ -72,7 +72,7 @@ impl From<Event> for iota_sdk::types::Event {
package_id: (**value.package_id),
module: Identifier::from_str(&value.module).unwrap(),
sender: (**value.sender),
type_: StructTag::from_str(&value.type_).unwrap(),
type_tag: StructTag::from_str(&value.type_tag).unwrap(),
contents: value.contents,
}
}
Expand All @@ -92,7 +92,7 @@ impl From<Event> for iota_sdk::graphql_client::query_types::Event {
address: (**value.sender),
}),
type_: MoveType {
repr: value.type_.clone(),
repr: value.type_tag.clone(),
},
bcs: Base64(base64ct::Base64::encode_string(&value.contents)),
timestamp: Some(DateTime(value.timestamp.clone())),
Expand All @@ -108,7 +108,7 @@ impl From<iota_sdk::types::Event> for Event {
package_id: Arc::new(value.package_id.into()),
module: value.module.to_string(),
sender: Arc::new(value.sender.into()),
type_: value.type_.to_string(),
type_tag: value.type_tag.to_string(),
contents: value.contents,
timestamp: String::new(),
data: String::new(),
Expand Down
Loading
Loading