add message definitions for State and ActionState #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature/add zone msgs cu 863gxkq86
…_CU-863h047hv Updated eStop enum to be in all caps
Updated message definitions
ipa-pfs
reviewed
Aug 1, 2023
| @@ -2,15 +2,16 @@ | |||
| int32 headerId # header ID of the message. The headerId is defined per topic and incremented by 1 with each sent | |||
| # (but not necessarily received) message. | |||
|
|
|||
| string timestamp # Timestamp after ISO8601 in the format YYYY-MM-DDTHH:mm:ss.ssZ (e.g.“2017-04-15T11:40:03.12Z”) | |||
| string timeStamp # Timestamp after ISO8601 in the format YYYY-MM-DDTHH:mm:ss.ssZ (e.g.“2017-04-15T11:40:03.12Z”) | |||
There was a problem hiding this comment.
In the document timestamp still seems to be lower case: https://github.com/VDA5050/VDA5050/blob/1.1.0/VDA5050_EN.md#actionStates Same applies to the other timestampes
ipa-pfs
reviewed
Aug 1, 2023
| @@ -2,9 +2,5 @@ float64 x # X coordinate described in the world coordinate system. | |||
|
|
|||
| float64 y # Y coordinate described in the world coordinate system. | |||
|
|
|||
| float64 orientation # [rad] Range [-pi...pi] Orientation of the AGV on this position of the curve. | |||
There was a problem hiding this comment.
orientation is still present in 1.1
|
Are you referring to 2.0? Because we would pin the current version to 1.1 and would make changes for version 2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some message definitions from VDA 5050 were missing, so we added them. The new definitions are based on version 1.1 of the guideline.